This repository has been archived by the owner on Dec 21, 2021. It is now read-only.
Adds a conditional action to build and push rpm and apt artifacts for pull requests to the dev repositories in nexus. #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soenkeliebau
requested review from
backstreetkiwi,
lfrancke,
maltesander and
siegfriedweber
|
Holding this for a bit because we're seeing errors in ZooKeeper with this code |
For PRs the version number is changed before building by adding the pr number as a suffix.
soenkeliebau
force-pushed
the
dev_artifacts
branch
from
07e3aa0
to
efe7924
Compare
lfrancke
previously approved these changes
May 25, 2021
|
Only one comment: It might be worth leaving a comment why you chose "mr" instead of "pr". Otherwise someone might change it in a year or so and then... |
lfrancke
approved these changes
May 25, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version numbers are built according to the following scheme: -pr<pr#>
So pr 14 for 0.1.0-nightly would result in a package with the version "0.1.0-pr14" being pushed.