Skip to content
This repository has been archived by the owner on Dec 21, 2021. It is now read-only.

Improve error message #276

Merged
merged 2 commits into from
Aug 30, 2021
Merged

Improve error message #276

merged 2 commits into from
Aug 30, 2021

Conversation

siegfriedweber
Copy link
Member

@siegfriedweber siegfriedweber commented Aug 27, 2021

Description

Error message improved which is logged if a systemd unit file cannot be created.

The log output looks like this:

[2021-08-27T13:14:26Z ERROR krator::state] Object state machine exited with error. error=Unit file [default-agent-service-integration-test.service] could not be created

    Caused by:
        0: File [/lib/systemd/system/default-agent-service-integration-test.service] could not be created
        1: Read-only file system (os error 30)

Fixes #47

Checklist

  • Code contains useful comments
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)

Error message improved which is logged if a systemd unit file cannot be
created.
@siegfriedweber siegfriedweber requested a review from a team August 27, 2021 15:03
@siegfriedweber siegfriedweber self-assigned this Aug 27, 2021
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@siegfriedweber siegfriedweber merged commit 47f379b into main Aug 30, 2021
@siegfriedweber siegfriedweber deleted the improve_error_message branch August 30, 2021 08:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Agent should be more helpful when it isn't allowed to interact with systemd
3 participants