-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt spark k8s versions for release 24.7 #771
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maltesander
changed the title
Add spark k8s versions 3.5.1 and 4.0.0-preview1
Add spark k8s version 4.0.0-preview1
Jul 11, 2024
maltesander
changed the title
Add spark k8s version 4.0.0-preview1
Adapt spark k8s versions for release 24.7
Jul 11, 2024
Maleware
reviewed
Jul 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR looks great.
Sadly I can't get a green test for this on arm64:
--- FAIL: kuttl (306.81s)
--- FAIL: kuttl/harness (0.00s)
--- FAIL: kuttl/harness/iceberg_openshift-false_spark-3.5.1,docker.stackable.tech_stackable-experimental_spark-k8s_3.5.1-stackable0.0.0-dev (306.79s)
FAIL
ERROR:root:kuttl failed
I will comment later again and approve if we get it fixed
There was a bug in the test template that is fixed here: stackabletech/spark-k8s-operator@70b5e68 |
razvan
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Definition of Done Checklist
Tasks
TIP: Running integration tests with a new product image
The image can be built and uploaded to the kind cluster with the following commands:
See the output of
bake
to retrieve the image tag for<image-tagged-with-the-major-version>
.