Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt spark k8s versions for release 24.7 #771

Merged
merged 9 commits into from
Jul 16, 2024

Conversation

maltesander
Copy link
Member

@maltesander maltesander commented Jul 11, 2024

Description

  • switch 3.5.1 to java 17
  • removed versions 3.4.1 and 3.5.0

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Tasks

TIP: Running integration tests with a new product image

The image can be built and uploaded to the kind cluster with the following commands:

bake --product <product> --image-version <stackable-image-version>
kind load docker-image <image-tagged-with-the-major-version> --name=<name-of-your-test-cluster>

See the output of bake to retrieve the image tag for <image-tagged-with-the-major-version>.

@maltesander maltesander requested a review from a team July 11, 2024 08:08
@maltesander maltesander self-assigned this Jul 11, 2024
@maltesander maltesander changed the title Add spark k8s versions 3.5.1 and 4.0.0-preview1 Add spark k8s version 4.0.0-preview1 Jul 11, 2024
@maltesander maltesander changed the title Add spark k8s version 4.0.0-preview1 Adapt spark k8s versions for release 24.7 Jul 11, 2024
@maltesander maltesander marked this pull request as ready for review July 11, 2024 12:59
Copy link
Contributor

@Maleware Maleware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks great.

Sadly I can't get a green test for this on arm64:

--- FAIL: kuttl (306.81s)
    --- FAIL: kuttl/harness (0.00s)
        --- FAIL: kuttl/harness/iceberg_openshift-false_spark-3.5.1,docker.stackable.tech_stackable-experimental_spark-k8s_3.5.1-stackable0.0.0-dev (306.79s)
FAIL
ERROR:root:kuttl failed

I will comment later again and approve if we get it fixed

@razvan
Copy link
Member

razvan commented Jul 15, 2024

Sadly I can't get a green test for this on arm64:

There was a bug in the test template that is fixed here: stackabletech/spark-k8s-operator@70b5e68

@maltesander maltesander added this pull request to the merge queue Jul 16, 2024
Merged via the queue into main with commit 9e02be2 Jul 16, 2024
14 checks passed
@maltesander maltesander deleted the chore/bump-spark-k8s-versions branch July 16, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants