Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix release yaml #29

Merged
merged 1 commit into from
Jun 14, 2023
Merged

Fix release yaml #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,6 @@ jobs:
password: ${{ secrets.GITHUB_TOKEN }}

- name: Push Docker image
env:
env:
XDG_CACHE_HOME: ~/.cache/bazel-repo
RELEASE_VERSION: ${{ steps.vars.outputs.tag }}
Expand Down
10 changes: 4 additions & 6 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,12 +100,10 @@ This file can be generated by the protoc `--descriptor_set_out` flag and is used
by other tools in the protobuf/gRPC ecosystem (see
[grpcurl](https://github.com/fullstorydev/grpcurl#protoset-files)).

For bazel users, the
[proto_descriptor_set](https://github.com/bazelbuild/rules_proto/blob/master/proto/private/rules/proto_descriptor_set.bzl) rule
can be used to generate this file.

> Have multiple descriptor files? You can simply `cat` multiple
> `FileDescriptorProto` binary files together!
For bazel users, the `proto_library` rule produces this as its output file. The
[proto_descriptor_set](https://github.com/bazelbuild/rules_proto/blob/master/proto/private/rules/proto_descriptor_set.bzl)
concatenates multiple descriptor sets together (`cat foo.descriptor.pb
bar.descriptor.pb > combined.descriptor.pb`).

### Script File

Expand Down