Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scss support + cli settings #1

Closed
luketn opened this issue Aug 3, 2017 · 19 comments
Closed

scss support + cli settings #1

luketn opened this issue Aug 3, 2017 · 19 comments

Comments

@luketn
Copy link

luketn commented Aug 3, 2017

Hi!
Absolutely love the app. Totally awesome.
One thing would be really cool - Sass (.scss file) support.
I'm a maintainer on an angular -> materlialize component and it would be handy to create some demo projects here, but we'd need .scss support and the ability to tweak the CLI settings a little to use the scss extension and load a couple of scripts.
Hope you can help!
Cheers,
Luke

@EricSimons
Copy link
Member

@luketn thanks for the kind words! And absolutely — scss support shouldn't be hard for us to implement :) What CLI settings are you looking to tweak?

@JoniWeiss
Copy link

JoniWeiss commented Aug 3, 2017

Create-react-app includes support for SCCS and LESS support. Why not, in the Settings panel (or a new Options panel), add options for SASS, LESS, and other options provided by the inclusion of the .env file in the create-react-app project directory? It would need to also be included on export.

@EricSimons
Copy link
Member

EricSimons commented Aug 6, 2017

@JoniWeiss Great idea! We can def do this 👍

@luketn Another q for ya — when you said "...and load a couple of scripts", what kind of scripts would you be looking to load?

@cwtuan
Copy link

cwtuan commented Aug 26, 2017

Does it has SASS support currently?

@EricSimons
Copy link
Member

EricSimons commented Sep 7, 2017

Hey all! We just shipped SASS and LESS support, and we also support the angular-cli.json config too :) You can check it out in action in the Angular starter template or my Angular Material starter template — would love hear your thoughts :)

@Sampath-Lokuge
Copy link

@EricSimons Aweseom. Thank you 👍 Hope stackblitz rocks the Ionic world too. See the example here.

https://stackoverflow.com/questions/46252546/add-scss-file-to-the-stackblitz

@sinedied
Copy link

sinedied commented Dec 6, 2017

@EricSimons any new for SASS support with React?

@seawatts
Copy link

@sinedied did you ever get this working?

@sinedied
Copy link

@seawatts Yes just rename styles.css to styles.scss and update the import

@seveves
Copy link
Collaborator

seveves commented Mar 26, 2018

@luketn may we close this issue? I think sass support is working now properly

@guillaumemach
Copy link

Hello,

We are testing the app ad it looks awesome.
Based on @EricSimons replies, how can we add less files ?

Thanks a lot !

@seveves
Copy link
Collaborator

seveves commented Apr 6, 2018

What do you mean with "how"? You can just add a file with the extension .less. Doesn't it work for you? Any related stackblitz project you can link to?

@guillaumemach
Copy link

guillaumemach commented Apr 6, 2018

Hello @seveves , sorry for my not well documented question. When we add a file with the extension .less, we get the following error message :
image

We were just trying the default demo. I am asking the question before digging further because all our css libs are using less

@seveves
Copy link
Collaborator

seveves commented Apr 6, 2018

@gmacherey what default template are you using? angular, react or another one? I will try to reproduce your issue and if it really does not work then we really should open a new issue 😬

@guillaumemach
Copy link

@seveves here are the exact steps I'm doing:

  1. Go to the main website : https://stackblitz.com/
  2. Click on Javascript Blank Project (https://stackblitz.com/fork/js)
  3. Try to add a less file : for example custom-style.less
  4. Hit enter
  5. I get the error described in my previous message

I hope I haven't misunderstood where this functionnality is available.

Thanks

@EricSimons
Copy link
Member

@gmacherey can you try it now? I just enabled LESS for both the JS & TS vanilla starter projects

@guillaumemach
Copy link

guillaumemach commented Apr 6, 2018

@EricSimons , thanks a lot.

The file is accepted now, and I can import it from the index.js file. However the styles from the less file does not seem to be applied.

Here is a very basic example: https://stackblitz.com/edit/js-mvvjqb?file=index.js
Should I set somewhere the preprocessor ?

Thanks again

@EricSimons
Copy link
Member

SHOOT I screwed that up lol. Can you try forking a new project on the homepage now? It should work :)

@guillaumemach
Copy link

@EricSimons no problem, this is working perfectly now. Thanks a lot !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants