Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced mounted kubeconfig with service account #30

Merged
merged 11 commits into from
Aug 17, 2023

Conversation

wtripp180901
Copy link
Contributor

Now uses a ServiceAccount with minimal permissions for power up/down scripts, which automatically mounts an API token for kubectl to use. The token is has a default expiration time of an hour but my understanding is that it gets refreshed, just need to test if it works after an hour
Recommend a squash merge, lots of useless image rebuilds in this

@wtripp180901 wtripp180901 requested a review from sjpb August 17, 2023 14:53
Copy link
Collaborator

@sjpb sjpb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will merge as not planning to merge the feat/autoscale branch yet anyway

@sjpb sjpb merged commit 96d933f into feat/autoscale Aug 17, 2023
@sjpb sjpb deleted the feat/autoscaler-service-account branch August 17, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants