Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ROX-12576 3.9.x arena segfault backport #862

Merged
merged 3 commits into from
Oct 5, 2022
Merged

ROX-12576 3.9.x arena segfault backport #862

merged 3 commits into from
Oct 5, 2022

Conversation

ovalenti
Copy link
Contributor

@ovalenti ovalenti commented Oct 5, 2022 •
edited
Loading

Description

This is a backport of 2d2c222 to fix #838 on the release-3.9.x release branch

Checklist

  • Investigated and inspected CI test results
  • [ ] Updated documentation accordingly

Automated testing

  • [ ] Added unit tests
  • [ ] Added integration tests
  • [ ] Added regression tests

@ovalenti
Crash with ProtoAllocator overflow (#848)
d711f5b 
Let protobuf's arena handle the default allocator case

While protobuf's documentation states that &malloc is the default value
for the allocator, the reader should understand that malloc is going to
be used in the default case, and not that the allocator option points
to it.
The null value in there was called when overflowing the pool size.
@ovalenti ovalenti self-assigned this Oct 5, 2022
@ovalenti ovalenti marked this pull request as ready for review October 5, 2022 14:26
@ovalenti ovalenti requested a review from a team as a code owner October 5, 2022 14:26
@openshift-ci
Copy link

openshift-ci bot commented Oct 5, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Molter73
Molter73 approved these changes Oct 5, 2022
View reviewed changes
Copy link
Collaborator

@Molter73 Molter73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ghost
Copy link

ghost commented Oct 5, 2022 

COLLECTOR_TAG=3.9.0-3-gcf1bdc7751
COLLECTOR_BUILDER_TAG=circle-build-7d8ef139-74a7-4353-b038-2d622037d18f

Results for Performance Benchmarks on build #285691

Kernel Method Without Collector Time (secs) With Collector Time (secs) Baseline median (secs) Collector median (secs) PValue
rhel.rhel-7 ebpf 226.024 274.758 174.18 216.51 🟢
rhel.rhel-7 module 255.852 269.094 186.64 212.5 🟢
rhel.rhel-8 ebpf 111.833 119.648 211.33 222.38 🟢
rhel.rhel-8 module 223.099 247.682 184.14 205.5 🟢
ubuntu-os-pro.ubuntu-pro-1804-lts ebpf 198.275 214.065 178.26 188.56 🟢
ubuntu-os-pro.ubuntu-pro-1804-lts module 189.588 224.389 183.11 211.77 🟢
ubuntu-os.ubuntu-1804-lts ebpf 190.213 219.411 189.4 215.19 🟢
ubuntu-os.ubuntu-1804-lts module 212.284 261.432 188.45 223.51 🟢
ubuntu-os.ubuntu-2004-lts ebpf 255.635 275.558 241.34 232.54 🟢
ubuntu-os.ubuntu-2004-lts module 223.448 247.065 222.91 239.84 🟢
ubuntu-os.ubuntu-2204-lts ebpf 216.821 218.395 210.66 222.07 🔴
ubuntu-os.ubuntu-2204-lts module 210.198 193.877 216.68 244.67 🔴

@ovalenti ovalenti merged commit 8335b73 into release/3.9.x Oct 5, 2022
@ovalenti ovalenti deleted the ovalenti/3.9-arena-segfault-backport branch October 5, 2022 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Molter73 Molter73 Molter73 approved these changes

Assignees

@ovalenti ovalenti

Labels
build-builder-image
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ovalenti @Molter73