-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CreateContextWithOptions #144
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aiyengar2
force-pushed
the
support_custom_scheme
branch
2 times, most recently
from
March 26, 2021 18:11
564a584
to
4a2e67c
Compare
aiyengar2
force-pushed
the
support_custom_scheme
branch
2 times, most recently
from
March 27, 2021 01:14
6637217
to
621b1d0
Compare
aiyengar2
changed the title
Add UseCustomScheme to lintcontext
Add CreateContextWithOptions
Mar 27, 2021
aiyengar2
force-pushed
the
support_custom_scheme
branch
2 times, most recently
from
March 27, 2021 01:20
a41085f
to
6cc5e58
Compare
Allows users to provide options for creating lint context. Related Issue: stackrox#141 Signed-off-by: Arvind Iyengar <arvind.iyengar@rancher.com>
aiyengar2
force-pushed
the
support_custom_scheme
branch
from
March 27, 2021 01:23
6cc5e58
to
244a173
Compare
This was referenced Mar 27, 2021
@viswajithiii I've followed up with #146, which exposes an additional option for providing additional values.yamls. |
viswajithiii
approved these changes
Mar 28, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. Please make the one change and I will merge this in. Thanks for the PR!
Signed-off-by: Arvind Iyengar <arvind.iyengar@rancher.com>
@viswajithiii left it as two commits, feel free to squash and merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow consumers of this package to provide non-default schemes to deserialize from or other advanced options via the options.
Related Issue: #141