Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CreateContextWithOptions #144

Merged
merged 2 commits into from
Mar 28, 2021

Conversation

aiyengar2
Copy link
Contributor

@aiyengar2 aiyengar2 commented Mar 26, 2021

This will allow consumers of this package to provide non-default schemes to deserialize from or other advanced options via the options.

Related Issue: #141

@aiyengar2 aiyengar2 force-pushed the support_custom_scheme branch 2 times, most recently from 6637217 to 621b1d0 Compare March 27, 2021 01:14
@aiyengar2 aiyengar2 changed the title Add UseCustomScheme to lintcontext Add CreateContextWithOptions Mar 27, 2021
@aiyengar2 aiyengar2 force-pushed the support_custom_scheme branch 2 times, most recently from a41085f to 6cc5e58 Compare March 27, 2021 01:20
Allows users to provide options for creating lint context.

Related Issue: stackrox#141

Signed-off-by: Arvind Iyengar <arvind.iyengar@rancher.com>
@aiyengar2
Copy link
Contributor Author

@viswajithiii I've followed up with #146, which exposes an additional option for providing additional values.yamls.

Copy link
Contributor

@viswajithiii viswajithiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Please make the one change and I will merge this in. Thanks for the PR!

pkg/lintcontext/create_contexts.go Outdated Show resolved Hide resolved
Signed-off-by: Arvind Iyengar <arvind.iyengar@rancher.com>
@aiyengar2
Copy link
Contributor Author

@viswajithiii left it as two commits, feel free to squash and merge it.

@viswajithiii viswajithiii merged commit cb34f2c into stackrox:main Mar 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants