Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(clar2wasm): $stdlib.is-valid-string-ascii missed a few chars #390

Merged
merged 2 commits into from
Apr 25, 2024

Conversation

Acaccia
Copy link
Collaborator

@Acaccia Acaccia commented Apr 24, 2024

Fixes #389

@Acaccia Acaccia self-assigned this Apr 24, 2024
@Acaccia Acaccia requested a review from csgui April 24, 2024 17:48
Copy link

codecov bot commented Apr 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.97%. Comparing base (3cac25c) to head (d287d9b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #390      +/-   ##
==========================================
+ Coverage   86.94%   86.97%   +0.02%     
==========================================
  Files          43       43              
  Lines       18232    18267      +35     
  Branches    18232    18267      +35     
==========================================
+ Hits        15852    15887      +35     
  Misses       1044     1044              
  Partials     1336     1336              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@csgui csgui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good job on finding that missing chars.

@Acaccia Acaccia added this pull request to the merge queue Apr 25, 2024
Merged via the queue into main with commit 80cd207 Apr 25, 2024
8 checks passed
@Acaccia Acaccia deleted the fix/deserialize-all-ascii branch April 25, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stdlib `$is-valid-string-ascii" does not account for all characters
2 participants