Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: simplify peg-in transaction signing #155

Merged
merged 5 commits into from
May 15, 2024
Merged

feat: simplify peg-in transaction signing #155

merged 5 commits into from
May 15, 2024

Conversation

djordon
Copy link
Contributor

@djordon djordon commented May 15, 2024

Description

Closes #152.

Each transaction input needs to be accompanied by a signed digest before being submitted to the bitcoin network. It is not obvious which steps need to be taken to construct this digest, so this PR adds helper functions that simplifies their creation.

Testing information

Provide context on how tests should be performed.

  1. There is already an integration test that constructs a transaction, signs it, and submits it to the bitcoin network. This PR updates that test to use the new helper functions. If bitcoind accepts our transaction, then things are likely constructed correctly.

@djordon djordon added the utxo consolidation Tickets related to how we consolidate deposit and withdrawal BTC transactions label May 15, 2024
@djordon djordon requested review from xoloki, hstove and netrome May 15, 2024 04:08
netrome
netrome approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@netrome netrome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice stuff. Just one question.

signer/src/utxo.rs Show resolved Hide resolved
signer/tests/integration/utxo_construction.rs Outdated Show resolved Hide resolved
@djordon djordon changed the title feat: simplify peg in transaction signing feat: simplify peg-in transaction signing May 15, 2024
@djordon djordon merged commit a22af2c into main May 15, 2024
3 checks passed
@djordon djordon deleted the 152-simplify-peg-in-transaction-signing branch May 15, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@netrome netrome netrome approved these changes

@xoloki xoloki Awaiting requested review from xoloki

@hstove hstove Awaiting requested review from hstove

Assignees
No one assigned
Labels
utxo consolidation Tickets related to how we consolidate deposit and withdrawal BTC transactions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: Simplify peg-in transaction signing
2 participants
@djordon @netrome