-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: extract sbtc contract calls block observer #315
feat: extract sbtc contract calls block observer #315
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great stuff so far. What we should also do (either here or as follow-ups) is to populate some dedicated tables for the different transaction types. We should:
- Parse any calls to
rotate-keys-wrapper
and write the updated signer set into a table. Right now the storage model has theaggregate_key_transactions
table that tracks the aggregate keys. I think we could rename this tokey_rotations
, and we also need to track the updated signer set, so we need to add a field for that as well. - Populate the
deposit_responses
andwithdraw_responses
tables in the state model.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, though how are we ultimately getting the data from the deleted functions? For example with the function below:
fn extract_update_signer_set_transactions(&self, _transactions: &[stacks::StacksTransaction]) {
// TODO(#208): Implement
}
Do we no longer need that data?
We do, it's just done in the |
Description
This might also address #209, but I'm not sure.
Changes
DbWrite
trait to use the model types as input. This keeps the interface a bit more logical and makes it easier to test.Testing information
This PR is mostly a refactor. The core functionality was added in 2e30ef3, but subsequent commits addressed some oddities in the previous code.