Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address clippy complaints in pox-locking repo #3950

Merged
merged 3 commits into from
Oct 16, 2023

Conversation

jferrant
Copy link
Collaborator

Closes #3937

To run clippy ONLY in pox-locking:
cargo clippy -p pox-locking --no-deps --tests --all-features

@jferrant jferrant added the chore Necessary but less impactful tasks such as cleanup or reorg label Sep 19, 2023
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #3950 (e5d529c) into develop (55b06c2) will decrease coverage by 58.16%.
Report is 4 commits behind head on develop.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##           develop    #3950       +/-   ##
============================================
- Coverage    58.31%    0.16%   -58.16%     
============================================
  Files            1      337      +336     
  Lines          571   287020   +286449     
============================================
+ Hits           333      469      +136     
- Misses         238   286551   +286313     
Files Coverage Δ
pox-locking/src/lib.rs 0.00% <ø> (ø)
pox-locking/src/events.rs 0.00% <0.00%> (ø)
pox-locking/src/pox_3.rs 0.00% <0.00%> (ø)
pox-locking/src/pox_1.rs 0.00% <0.00%> (ø)
pox-locking/src/pox_2.rs 0.00% <0.00%> (ø)

... and 331 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jferrant jferrant force-pushed the chore/pox-locking-fix-clippy branch 2 times, most recently from eac948f to 29ea42a Compare October 3, 2023 22:11
@jferrant jferrant requested a review from jcnelson October 3, 2023 22:12
@jferrant jferrant force-pushed the chore/pox-locking-fix-clippy branch from 29ea42a to e8df625 Compare October 4, 2023 19:23
jferrant and others added 3 commits October 16, 2023 14:33
Signed-off-by: Jacinta Ferrant <jacinta@trustmachines.co>
Signed-off-by: Jacinta Ferrant <jacinta@trustmachines.co>
@xoloki xoloki force-pushed the chore/pox-locking-fix-clippy branch from 6fc2b22 to e5d529c Compare October 16, 2023 18:41
@xoloki xoloki merged commit 959a6e6 into develop Oct 16, 2023
1 of 2 checks passed
@xoloki xoloki deleted the chore/pox-locking-fix-clippy branch October 16, 2023 20:09
@blockstack-devops
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Nov 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
chore Necessary but less impactful tasks such as cleanup or reorg locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants