Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stack-aggregation-increase command #4651

Conversation

BowTiedRadone
Copy link
Contributor

This PR adds the stack-aggregation-commit command, using both signature and authorization, to the stateful property testing environment. It is part of #4548 and targets feat/pox-4-stateful-property-testing (#4550).

Adding the `StackAggregationIncreaseCommand` is currently causing the tests to fail.
To investigate:
- this may be a PoX-4 bug
- this may be a command implementation issue
@BowTiedRadone
Copy link
Contributor Author

@friedger @moodmosaic @setzeus adding the stack-aggregation-increase brought up some intermittent test failures. I have saved the error traces (that I'll continue investigating after the command is merged).

In case the command is correct, there may be some PoX-4 unexpected behavior.

Thank you in advance!

@BowTiedRadone
Copy link
Contributor Author

Closed this PR in favor of #4652

@moodmosaic moodmosaic deleted the feat/pox-4-stateful-stack-agg-increase branch April 17, 2024 11:28
@blockstack-devops
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Nov 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants