chore: wip

Author: chrisbbreuer

storage/framework/core/chat/build.ts

@@ -1,3 +1,4 @@
+import { dts } from 'bun-plugin-dts-auto'
 import { intro, outro } from '../build/src'
 
 const { startTime } = await intro({
@@ -12,6 +13,7 @@ const result = await Bun.build({
   sourcemap: 'linked',
   minify: true,
   external: ['@stacksjs/cli', '@stacksjs/error-handling'],
+  plugins: [dts({ root: './src', outdir: './dist' })],
 })
 
 await outro({

storage/framework/core/cli/build.ts

@@ -1,7 +1,5 @@
+import { dts } from 'bun-plugin-dts-auto'
 import { intro, outro } from '../build/src'
-import { dts } from './dts'
-
-// import { dts } from 'bun-plugin-dts-auto'
 
 const { startTime } = await intro({
   dir: import.meta.dir,
@@ -25,10 +23,10 @@ const result = await Bun.build({
   ],
 
   plugins: [
-    // dts({
-    //   root: './src',
-    //   outdir: './dist',
-    // }),
+    dts({
+      root: './src',
+      outdir: './dist',
+    }),
   ],
 })
 

storage/framework/core/cli/dts.ts

@@ -1,6 +1,6 @@
 import process from 'node:process'
 import { type Result, err, handleError, ok } from '@stacksjs/error-handling'
-import type { CliOptions, Subprocess } from '@stacksjs/types'
+import type { CliOptions, ErrorLike, SpawnOptions, Subprocess } from '@stacksjs/types'
 import { ExitCode } from '@stacksjs/types'
 import { italic, log } from './'
 
@@ -42,7 +42,12 @@ export async function exec(command: string | string[], options?: CliOptions): Pr
     detached: options?.background || false,
     cwd,
     // env: { ...e, ...options?.env },
-    onExit(subprocess, exitCode, signalCode, error) {
+    onExit(
+      subprocess: Subprocess<SpawnOptions.Writable, SpawnOptions.Readable, SpawnOptions.Readable>,
+      exitCode: number | null,
+      signalCode: number | null,
+      error: ErrorLike | undefined,
+    ) {
       exitHandler('spawn', subprocess, exitCode, signalCode, error)
     },
   })
@@ -98,12 +103,17 @@ export async function execSync(command: string | string[], options?: CliOptions)
     stderr: options?.stderr ?? 'inherit',
     cwd: options?.cwd ?? process.cwd(),
     // env: { ...Bun.env, ...options?.env },
-    onExit(subprocess, exitCode, signalCode, error) {
+    onExit(
+      subprocess: Subprocess<SpawnOptions.Writable, SpawnOptions.Readable, SpawnOptions.Readable>,
+      exitCode: number | null,
+      signalCode: number | null,
+      error: ErrorLike | undefined,
+    ) {
       exitHandler('spawnSync', subprocess, exitCode, signalCode, error)
     },
   })
 
-  return proc.stdout.toString()
+  return proc.stdout?.toString() ?? ''
 }
 
 function exitHandler(

storage/framework/core/cli/src/exec.ts

@@ -1,3 +1,4 @@
+import { dts } from 'bun-plugin-dts-auto'
 import { intro, outro } from '../build/src'
 
 const { startTime } = await intro({
@@ -24,6 +25,12 @@ const result = await Bun.build({
     '@stacksjs/cli',
     'aws-cdk-lib', // TODO: a recent AWS issue. We want to potentially remove this once the issue is resolved. Dig deeper into this before removing
   ],
+  plugins: [
+    dts({
+      root: './src',
+      outdir: './dist',
+    }),
+  ],
 })
 
 // Building the edge/origin-request separately

storage/framework/core/cloud/build.ts

@@ -10,7 +10,7 @@ export class AiStack {
     const bedrockAccessPolicy = new iam.PolicyStatement({
       effect: iam.Effect.ALLOW,
       actions: ['bedrock:InvokeModel', 'bedrock:InvokeModelWithResponseStream'],
-      resources: config.ai.models?.map((model) => `arn:aws:bedrock:us-east-1::foundation-model/${model}`),
+      resources: config.ai.models?.map((model: string) => `arn:aws:bedrock:us-east-1::foundation-model/${model}`),
     })
 
     const bedrockAccessRole = new iam.Role(scope, 'BedrockAccessRole', {

storage/framework/core/cloud/src/cloud/ai.ts

@@ -12,7 +12,7 @@ export interface DeploymentStackProps extends NestedCloudProps {
   docsBucket?: s3.Bucket
   privateBucket: s3.Bucket
   mainDistribution: cloudfront.Distribution
-  docsDistribution: cloudfront.Distribution
+  docsDistribution?: cloudfront.Distribution
 }
 
 export class DeploymentStack {
@@ -64,7 +64,7 @@ export class DeploymentStack {
     }
   }
 
-  shouldDeployDocs() {
+  shouldDeployDocs(): boolean {
     return hasFiles(p.projectPath('docs')) && !config.app.docMode
   }
 }

storage/framework/core/cloud/src/cloud/deployment.ts

@@ -92,7 +92,7 @@ export class Cloud extends Stack {
 
   // we use an async init() method here because we need to wait for the
 
-  async init() {
+  async init(): Promise<void> {
     const props = this.props
 
     if (this.shouldDeployApi()) {
@@ -122,7 +122,6 @@ export class Cloud extends Stack {
       firewall: this.security.firewall,
       originRequestFunction: this.docs.originRequestFunction,
       zone: this.dns.zone,
-      cliSetupUrl: this.cli.cliSetupUrl,
       lb: this.api?.lb,
     })
 
@@ -131,11 +130,12 @@ export class Cloud extends Stack {
       publicBucket: this.storage.publicBucket,
       privateBucket: this.storage.privateBucket,
       docsBucket: this.storage.docsBucket,
-      cdn: this.cdn.distribution,
+      mainDistribution: this.cdn.mainDistribution,
+      docsDistribution: this.cdn.docsDistribution,
     })
   }
 
-  shouldDeployApi() {
-    return config.cloud.api?.deploy
+  shouldDeployApi(): boolean {
+    return config.cloud.api?.deploy ?? false
   }
 }

storage/framework/core/cloud/src/cloud/index.ts

@@ -22,7 +22,7 @@ export class QueueStack {
     this.props = props
   }
 
-  async init() {
+  async init(): Promise<void> {
     const jobsDir = path.jobsPath()
     const actionsDir = path.appPath('Actions')
     const ormActionDir = path.builtUserActionsPath('src')
@@ -86,14 +86,14 @@ export class QueueStack {
     }
   }
 
-  async loadModule(filePath: string) {
+  async loadModule(filePath: string): Promise<{ default: any }> {
     const jobModule = await import(filePath)
 
     return jobModule
   }
 
   // TODO: narrow any type -> jobs & actions are allowed
-  createQueueRule(module: { default: any }, file: string) {
+  createQueueRule(module: { default: any }, file: string): void {
     // Now you can safely access module.default.rate
     const rate = module.default?.rate
 

storage/framework/core/cloud/src/cloud/queue.ts

@@ -12,11 +12,11 @@ export class RedirectsStack {
 
   constructor(scope: Construct, props: RedirectsStackProps) {
     // for each redirect, create a bucket & redirect it to the APP_URL
-    config.dns.redirects?.forEach((redirect) => {
+    config.dns.redirects?.forEach((redirect: string) => {
       // TODO: use string-ts function here instead
       const slug = redirect
         .split('.')
-        .map((part, index) => (index === 0 ? part : part.charAt(0).toUpperCase() + part.slice(1)))
+        .map((part: string, index: number) => (index === 0 ? part : part.charAt(0).toUpperCase() + part.slice(1)))
         .join('') // creates a CamelCase slug from the redirect
       const hostedZone = route53.HostedZone.fromLookup(scope, 'HostedZone', {
         domainName: redirect,
@@ -40,10 +40,10 @@ export class RedirectsStack {
     })
 
     // TODO: fix this – redirects do not work yet
-    config.dns.redirects?.forEach((redirect) => {
+    config.dns.redirects?.forEach((redirect: string) => {
       const slug = redirect
         .split('.')
-        .map((part, index) => (index === 0 ? part : part.charAt(0).toUpperCase() + part.slice(1)))
+        .map((part: string, index: number) => (index === 0 ? part : part.charAt(0).toUpperCase() + part.slice(1)))
         .join('') // creates a CamelCase slug from the redirect
       const hostedZone = route53.HostedZone.fromLookup(scope, `RedirectHostedZone${slug}`, { domainName: redirect })
       this.redirectZones.push(hostedZone)