chore: wip

Author: chrisbbreuer

storage/framework/core/arrays/build.ts

@@ -1,3 +1,4 @@
+import { dts } from 'bun-plugin-dts-auto'
 import { intro, outro } from '../build/src'
 
 const { startTime } = await intro({
@@ -12,6 +13,7 @@ const result = await Bun.build({
   sourcemap: 'linked',
   minify: true,
   external: ['@stacksjs/utils'],
+  plugins: [dts()],
 })
 
 await outro({

storage/framework/core/arrays/src/contains.ts

@@ -9,7 +9,7 @@
  * contains('foo', ['bar']) // false
  * ```
  */
-export function contains(needle: string, haystack: string[]) {
+export function contains(needle: string, haystack: string[]): boolean {
   return haystack.some((hay) => needle.includes(hay))
 }
 
@@ -23,7 +23,7 @@ export function contains(needle: string, haystack: string[]) {
  * containsAll(['foo', 'bar'], ['foo', 'baz']) // false
  * ```
  */
-export function containsAll(needles: string[], haystack: string[]) {
+export function containsAll(needles: string[], haystack: string[]): boolean {
   return needles.every((needle) => contains(needle, haystack))
 }
 
@@ -38,7 +38,7 @@ export function containsAll(needles: string[], haystack: string[]) {
  * containsAny(['foo', 'bar'], ['baz']) // false
  * ```
  */
-export function containsAny(needles: string[], haystack: string[]) {
+export function containsAny(needles: string[], haystack: string[]): boolean {
   return needles.some((needle) => contains(needle, haystack))
 }
 
@@ -53,7 +53,7 @@ export function containsAny(needles: string[], haystack: string[]) {
  * containsNone(['foo', 'bar'], ['baz']) // true
  * ```
  */
-export function containsNone(needles: string[], haystack: string[]) {
+export function containsNone(needles: string[], haystack: string[]): boolean {
   return !containsAny(needles, haystack)
 }
 
@@ -68,7 +68,7 @@ export function containsNone(needles: string[], haystack: string[]) {
  * containsOnly(['foo', 'bar'], ['foo', 'bar']) // true
  * ```
  */
-export function containsOnly(needles: string[], haystack: string[]) {
+export function containsOnly(needles: string[], haystack: string[]): boolean {
   return containsAll(haystack, needles)
 }
 
@@ -82,6 +82,6 @@ export function containsOnly(needles: string[], haystack: string[]) {
  * doesNotContain('foo', ['bar']) // true
  * ```
  */
-export function doesNotContain(needle: string, haystack: string[]) {
+export function doesNotContain(needle: string, haystack: string[]): boolean {
   return !contains(needle, haystack)
 }

storage/framework/core/arrays/src/helpers.ts

@@ -31,8 +31,8 @@ export function toArray<T>(array?: Nullable<Arrayable<T>>): Array<T> {
  * flatten([1, [2, [3, [4, [5]]]]]) // [1, 2, 3, 4, 5]
  * ```
  */
-export function flatten<T>(array?: Nullable<Arrayable<T | Array<T>>>): Array<T> {
-  return toArray(array).reduce((acc, val) => acc.concat(Array.isArray(val) ? flatten(val) : val), [] as T[])
+export function flatten<T>(array?: Nullable<Arrayable<T | T[]>>): T[] {
+  return toArray(array).reduce((acc: T[], val) => acc.concat(Array.isArray(val) ? flatten(val) : (val as T)), [])
 }
 
 /**
@@ -181,7 +181,7 @@ export function last<T>(array: readonly T[]): T | undefined {
  * Arr.remove(arr, 4) // false
  * console.log(arr) // [1, 3]
  */
-export function remove<T>(array: T[], value: T) {
+export function remove<T>(array: T[], value: T): boolean {
   if (!array) return false
 
   const index = array.indexOf(value)
@@ -258,7 +258,7 @@ export function move<T>(array: T[], from: number, to: number): T[] {
  * clampArrayRange([1, 2, 3], 4) // 2
  * clampArrayRange([1, 2, 3], -1) // 0
  */
-export function clampArrayRange(arr: readonly unknown[], n: number) {
+export function clampArrayRange(arr: readonly unknown[], n: number): number {
   return clamp(n, 0, arr.length - 1)
 }
 
@@ -271,8 +271,9 @@ export function clampArrayRange(arr: readonly unknown[], n: number) {
  * sample([1, 2, 3, 4], 2) // [2, 3]
  * ```
  */
-export function sample<T>(arr: T[], count: number) {
-  return Array.from({ length: count }, (_) => arr[Math.round(Math.random() * (arr.length - 1))])
+export function sample<T>(arr: T[], count: number): T[] {
+  // biome-ignore lint/style/noNonNullAssertion: it should be fine, open to improvements
+  return Array.from({ length: count }, () => arr[Math.floor(Math.random() * arr.length)]!)
 }
 
 /**

storage/framework/core/arrays/src/macro.ts

@@ -19,36 +19,36 @@ import {
 import { average, median, mode, range, sum } from './math'
 
 export const Arr = {
-  contains(needle: string, haystack: string[]) {
+  contains(needle: string, haystack: string[]): boolean {
     return contains(needle, haystack)
   },
 
-  containsAll(needles: string[], haystack: string[]) {
+  containsAll(needles: string[], haystack: string[]): boolean {
     return containsAll(needles, haystack)
   },
 
-  containsAny(needles: string[], haystack: string[]) {
+  containsAny(needles: string[], haystack: string[]): boolean {
     return containsAny(needles, haystack)
   },
 
-  containsNone(needles: string[], haystack: string[]) {
+  containsNone(needles: string[], haystack: string[]): boolean {
     return containsNone(needles, haystack)
   },
 
-  containsOnly(needles: string[], haystack: string[]) {
+  containsOnly(needles: string[], haystack: string[]): boolean {
     return containsOnly(needles, haystack)
   },
 
-  doesNotContain(needle: string, haystack: string[]) {
+  doesNotContain(needle: string, haystack: string[]): boolean {
     return doesNotContain(needle, haystack)
   },
 
   toArray<T>(array?: Nullable<Arrayable<T>>): Array<T> {
     return toArray(array)
   },
 
-  flatten<T>(array?: Nullable<Arrayable<T | Array<T>>>): Array<T> {
-    return toArray(array).reduce((acc, val) => acc.concat(Array.isArray(val) ? flatten(val) : val), [] as T[])
+  flatten<T>(array?: Nullable<Arrayable<T | T[]>>): T[] {
+    return flatten(array)
   },
 
   mergeArrayable<T>(...args: Nullable<Arrayable<T>>[]): Array<T> {
@@ -70,11 +70,7 @@ export const Arr = {
    * Returns random item/s from the array
    */
   sample<T>(arr: T[], count = 1): T[] {
-    // Get the sample array (may contain undefined values)
-    const sampleArr = sample(arr, count)
-
-    // Filter out any undefined values
-    return sampleArr.filter((item): item is T => item !== undefined)
+    return sample(arr, count)
   },
 
   unique<T>(arr: T[]): T[] {
@@ -89,7 +85,7 @@ export const Arr = {
     return last(arr)
   },
 
-  remove<T>(arr: T[], value: T) {
+  remove<T>(arr: T[], value: T): boolean {
     return remove(arr, value)
   },
 
@@ -105,7 +101,7 @@ export const Arr = {
     return move(arr, from, to)
   },
 
-  clampArrayRange(arr: readonly unknown[], n: number) {
+  clampArrayRange(arr: readonly unknown[], n: number): number {
     return clampArrayRange(arr, n)
   },
 
@@ -146,4 +142,4 @@ export const Arr = {
   },
 }
 
-export const arr = Arr
+export const arr: typeof Arr = Arr

storage/framework/core/arrays/src/math.ts

@@ -199,8 +199,8 @@ export function percentile(array: number[], num: number): number {
   const upper = Math.ceil(index)
   const weight = index - lower
 
-  if (upper === lower) return sorted[index]
-  return (1 - weight) * sorted[lower] + weight * sorted[upper]
+  if (upper === lower) return sorted[index] ?? 0
+  return (1 - weight) * (sorted[lower] ?? 0) + weight * (sorted[upper] ?? 0)
 }
 
 /**

storage/framework/core/cli/build.ts

@@ -1,7 +1,8 @@
-// import { dts } from 'bun-plugin-dts-auto'
 import { intro, outro } from '../build/src'
 import { dts } from './dts'
 
+// import { dts } from 'bun-plugin-dts-auto'
+
 const { startTime } = await intro({
   dir: import.meta.dir,
 })