chore: wip

Author: chrisbbreuer

app/Listener.ts

@@ -3,7 +3,7 @@ import { path as p } from '@stacksjs/path'
 import events from './Events'
 
 for (const key in events) {
-  if (events.hasOwnProperty(key)) {
+  if (Object.hasOwn(events, key)) {
     const eventKey = key
     const eventListeners = events[key]
 
@@ -20,13 +20,13 @@ for (const key in events) {
           listen(eventKey, e => actionModule.default.handle(e))
         }
         catch (error) {
-          console.error('Module not found:', modulePath)
+          handleError(`Module not found: ${modulePath}`, error)
         }
       }
     }
   }
 }
 
-function isFunction(val: unknown): val is Function {
+function isFunction(val: unknown) {
   return typeof val === 'function'
 }

storage/framework/core/events/tests/events.test.ts

@@ -5,7 +5,7 @@ import { all, dispatch, events, listen, mitt, off, useEvent, useEvents } from '.
 describe('@stacksjs/events', () => {
   test('mitt creates a functional event emitter', () => {
     const emitter = mitt<{ test: string }>()
-    const handler = mock((data: string) => {})
+    const handler = mock(() => {})
 
     emitter.on('test', handler)
     emitter.emit('test', 'hello')
@@ -15,7 +15,7 @@ describe('@stacksjs/events', () => {
 
   test('off removes event listeners', () => {
     const emitter = mitt<{ test: string }>()
-    const handler = mock((data: string) => {})
+    const handler = mock(() => {})
 
     emitter.on('test', handler)
     emitter.off('test', handler)
@@ -26,7 +26,7 @@ describe('@stacksjs/events', () => {
 
   test('wildcard listeners receive all events', () => {
     const emitter = mitt<{ test1: string, test2: number }>()
-    const handler = mock((type: string, data: any) => {})
+    const handler = mock(() => {})
 
     emitter.on('*', handler)
     emitter.emit('test1', 'hello')
@@ -39,8 +39,8 @@ describe('@stacksjs/events', () => {
 
   test('off removes all listeners of a given type when no handler is provided', () => {
     const emitter = mitt<{ test: string }>()
-    const handler1 = mock((data: string) => {})
-    const handler2 = mock((data: string) => {})
+    const handler1 = mock(() => {})
+    const handler2 = mock(() => {})
 
     emitter.on('test', handler1)
     emitter.on('test', handler2)
@@ -52,28 +52,28 @@ describe('@stacksjs/events', () => {
   })
 
   test('events creates a mitt instance with StacksEvents', () => {
-    const emitter = events()
+    const emitter = events
     expect(emitter).toHaveProperty('on')
     expect(emitter).toHaveProperty('off')
     expect(emitter).toHaveProperty('emit')
   })
 
   test('listen is an alias for on', () => {
-    const handler = mock((data: object) => {})
+    const handler = mock(() => {})
     listen('user:registered', handler)
     dispatch('user:registered', { name: 'John Doe' })
     expect(handler).toHaveBeenCalledWith({ name: 'John Doe' })
   })
 
   test('dispatch is an alias for emit', () => {
-    const handler = mock((data: object) => {})
+    const handler = mock(() => {})
     listen('user:logged-in', handler)
     dispatch('user:logged-in', { userId: 1 })
     expect(handler).toHaveBeenCalledWith({ userId: 1 })
   })
 
   test('useEvent is an alias for emit', () => {
-    const handler = mock((data: object) => {})
+    const handler = mock(() => {})
     listen('user:logged-out', handler)
     useEvent('user:logged-out', { userId: 1 })
     expect(handler).toHaveBeenCalledWith({ userId: 1 })
@@ -86,22 +86,22 @@ describe('@stacksjs/events', () => {
   })
 
   test('all provides access to the event handler map', () => {
-    const handler = mock((data: Partial<UserModel>) => {})
+    const handler = mock(() => {})
     listen('user:updated', handler)
     expect(all.get('user:updated')).toContain(handler)
   })
 
   test('off removes a specific listener', () => {
-    const handler = mock((data: object) => {})
+    const handler = mock(() => {})
     listen('user:password-changed', handler)
     off('user:password-changed', handler)
     dispatch('user:password-changed', { userId: 1 })
     expect(handler).not.toHaveBeenCalled()
   })
 
   test('multiple events can be handled', () => {
-    const registeredHandler = mock((data: object) => {})
-    const updatedHandler = mock((data: UserModel) => {})
+    const registeredHandler = mock(() => {})
+    const updatedHandler = mock(() => {})
 
     listen('user:registered', registeredHandler)
     listen('user:updated', updatedHandler)

storage/framework/core/logging/src/index.ts

@@ -1,3 +1,4 @@
+/* eslint no-console: 0 */
 import process from 'node:process'
 import { buddyOptions, stripAnsi } from '@stacksjs/cli'
 import { handleError, writeToLogFile } from '@stacksjs/error-handling'

storage/framework/core/router/src/router.ts

@@ -1,5 +1,6 @@
 import type { Action } from '@stacksjs/actions'
 import type { Job, RedirectCode, Route, RouteGroupOptions, RouterInterface, StatusCode } from '@stacksjs/types'
+import { handleError } from '@stacksjs/error-handling'
 import { log } from '@stacksjs/logging'
 import { path as p } from '@stacksjs/path'
 import { kebabCase, pascalCase } from '@stacksjs/strings'
@@ -112,7 +113,7 @@ export class Router implements RouterInterface {
       return this.addRoute(action.method ?? 'GET', this.prepareUri(path), action.handle, 200)
     }
     catch (error) {
-      log.error(`Could not find Action for path: ${path}`)
+      handleError(`Could not find Action for path: ${path}`, error)
 
       return this
     }

storage/framework/core/scheduler/src/schedule.ts

@@ -103,6 +103,7 @@ export class Schedule {
   }
 
   start(): void {
+    // eslint-disable-next-line no-new
     new CronJob(this.cronPattern, this.task, null, true, this.timezone)
     log.info(`Scheduled task with pattern: ${this.cronPattern} in timezone: ${this.timezone}`)
   }

storage/framework/core/search-engine/src/index.ts

@@ -46,7 +46,7 @@ export function calculatePagination(): void {
   if (table.perPage)
     totalPages.value = Math.ceil(totalHits / table.perPage)
 
-  const hitPages = [...new Array(totalPages.value).keys()].map(i => i + 1)
+  const hitPages = Array.from({ length: totalPages.value }, (_, i) => i + 1)
   const offset = 2
   const currentPage = table.currentPage ?? 1
   const lastPage = hitPages[hitPages.length - 1]

storage/framework/core/storage/src/files.ts

@@ -1,5 +1,6 @@
 import type { JsonFile, PackageJson, TextFile } from '@stacksjs/types'
 import { contains } from '@stacksjs/arrays'
+import { log } from '@stacksjs/logging'
 import { dirname, join, path as p } from '@stacksjs/path'
 import { detectIndent, detectNewline } from '@stacksjs/strings'
 import { createFolder, isFolder } from './'
@@ -108,6 +109,7 @@ export function hasFiles(folder: string): boolean {
     return fs.readdirSync(folder).length > 0
   }
   catch (err) {
+    log.debug(`Error reading folder: ${folder}`, err)
     return false
   }
 }

storage/framework/core/testing/src/dynamodb.ts

@@ -1,3 +1,4 @@
+import process from 'node:process'
 import {
   CreateTableCommand,
   DeleteTableCommand,

storage/framework/core/tunnel/src/tunnel.ts

@@ -7,6 +7,7 @@ export async function localTunnel(options?: { port: number }): Promise<LocalTunn
   if (!options?.port)
     options = { port }
 
+  // eslint-disable-next-line no-console
   console.log('Creating local tunnel', options.port)
 
   return 'localTunnel'

storage/framework/core/types/src/notifications.ts

@@ -145,11 +145,7 @@ export interface NotificationOptions {
         secret: string
       }
 
-      discord?: {
-        // appId: string
-        // clientId: string
-        // secret: string
-      }
+      // discord?: {}
     }
   }
 }