chore: wip

Author: chrisbbreuer

storage/framework/core/actions/src/key-generate.ts

@@ -1,10 +1,10 @@
 import { runCommand } from '@stacksjs/cli'
 import { projectPath } from '@stacksjs/path'
 import { generateAppKey } from '@stacksjs/security'
-import { isFile } from '@stacksjs/storage'
+import { fs } from '@stacksjs/storage'
 import { setEnvValue } from '@stacksjs/utils'
 
-if (!isFile('.env'))
+if (!(await fs.exists('.env')))
   await runCommand('cp .env.example .env', { cwd: projectPath() })
 
 await setEnvValue('APP_KEY', generateAppKey())

storage/framework/core/orm/src/utils.ts

@@ -1423,7 +1423,7 @@ export async function generateModelString(
       static async remove(id: number): Promise<void> {
         const instance = new ${modelName}Model(null)
         ${mittDeleteFindStatement}
-        
+
         if (instance.softDeletes) {
         await db.updateTable('${tableName}')
           .set({
@@ -1825,48 +1825,15 @@ export async function generateModelFiles(modelStringFile?: string): Promise<void
 
     log.info('Ensuring Code Style...')
     try {
-      // we run this in background in background, because we simply need to lint:fix the auto-generated code
-      // the reason we run it in background is because we don't care whether it fails or not, given there
-      // is a chance that the codebase has lint issues unrelating to our auto-generated code
-      const process = Bun.spawn(['bunx', '--bun', 'eslint', '.', '--fix'], {
-        stdio: ['ignore', 'pipe', 'pipe'],
+      Bun.spawn(['bunx', '--bun', 'eslint', '.', '--fix'], {
+        stdio: ['ignore', 'ignore', 'ignore'],
         cwd: path.projectPath(),
         detached: true,
       })
-
-      const reader = process.stdout.getReader()
-      // let output = ''
-
-      while (true) {
-        const { done } = await reader.read()
-        if (done)
-          break
-        // output += new TextDecoder().decode(value)
-      }
-
-      const stderrReader = process.stderr.getReader()
-      while (true) {
-        const { done } = await stderrReader.read()
-        if (done)
-          break
-        // Collect stderr output but do not log it
-        // output += new TextDecoder().decode(value)
-      }
-
-      const exitCode = await process.exited
-
-      if (exitCode !== 0) {
-        log.debug(
-          'There was an error fixing your code style but we are ignoring it because we fixed the auto-generated code already.',
-        )
-      }
-      else {
-        log.success('Code style fixed successfully.')
-      }
+      log.success('Code style fixing started in background.')
     }
     catch (error) {
-      handleError('There was an error fixing your code style.', error)
-      process.exit(ExitCode.FatalError)
+      handleError('There was an error starting the code style fixing process.', error)
     }
 
     log.success('Linted')

storage/framework/core/storage/src/delete.ts

@@ -2,7 +2,6 @@ import type { Result } from '@stacksjs/error-handling'
 import { italic, log } from '@stacksjs/cli'
 import { err, handleError, ok } from '@stacksjs/error-handling'
 import { join } from '@stacksjs/path'
-import { isFile } from './files'
 import { isFolder } from './folders'
 import { fs } from './fs'
 import { glob } from './glob'
@@ -85,7 +84,7 @@ export async function deleteEmptyFolders(dir: string): Promise<Result<string, Er
 export function deleteFile(path: string): Promise<Result<string, Error>> {
   return new Promise((resolve, reject) => {
     try {
-      if (isFile(path)) {
+      if (fs.statSync(path).isFile()) {
         fs.rmSync(path, { recursive: true, force: true })
         return resolve(ok(`Deleted ${path}`))
       }
@@ -118,7 +117,7 @@ export async function deleteGlob(path: string): Promise<Result<string, Error>> {
 }
 
 export async function del(path: string): Promise<Result<string, Error>> {
-  if (isFile(path))
+  if (fs.existsSync(path) && fs.statSync(path).isFile())
     return await deleteFile(path)
 
   if (isFolder(path))

storage/framework/core/storage/src/files.ts

@@ -174,7 +174,6 @@ export interface Files {
   readTextFile: typeof readTextFile
   writeJsonFile: typeof writeJsonFile
   writeTextFile: typeof writeTextFile
-  isFile: typeof isFile
   hasFiles: typeof hasFiles
   hasComponents: typeof hasComponents
   hasFunctions: typeof hasFunctions
@@ -190,7 +189,6 @@ export const files: Files = {
   readTextFile,
   writeJsonFile,
   writeTextFile,
-  isFile,
   hasFiles,
   hasComponents,
   hasFunctions,