-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to generate file list on Netgear WAX620 #12
Comments
Hey there, Thanks for the report! Adding a flag to allow skipping unprocessable archives with a warning is definitely a great idea, and shouldn't be too much effort to implement. I'll take a look at adding support for this shortly. I'll also have a look into this specific archive to see whether the format is non-standard, and if so, whether there's anything that can be done to have STACS support it. |
It is also possible that the file is corrupt as we try to extract everything that is possible with different mechanisms and there it happens that files are broken. |
This commit allows the user to continue processing data when an archive is unable to be extracted. This is useful in cases where a single archive may be corrupt in a large run. This commit also introduces additional debug messages when STACS is run with the `--debug` flag, in order to provide more visibility during development and troubleshooting. This change has been added to resolve Github issue #12.
Hey there, Looks like you're correct for this one. According to my tests using the same firmware image (
That said, with the changes staged ready for 0.4.3 you can now skip these unprocessable / corrupt archives using the "skip unprocessable" flag. This defaults to False so that it's not a breaking change, and so the user has to explicitly request this behaviour to avoid confusion:
When using this new option you will still be warned for every file which is considered unprocessable, but STACS will not error and exit:
I'm just running a few manual regression tests before I cut a new release, which will trigger an upload to both PyPI and Dockerhub shortly afterwards. Thanks again for the report, and please let us know if you're happy that this change resolves this issue. |
Hey there, This has just been released, hopefully this resolves this issue :) Cheers |
This looks really good. Thank you for the update. I will include this update also into EMBA. Keep the great work! |
Hi, currently I do some evaluations of STACS - you can also see our integration into the Firmware Scanner EMBA here: e-m-b-a/emba#207
During these tasks I have done some tests on the Netgear firmware WAX620 from here: https://www.netgear.com/support/product/wax630.aspx#Firmware%20Version%209.5.4.6
During these tests STACS is running into the following error:
Before running STACS the extractor of EMBA has extracted the firmware and then I started STACS the shown way.
Is there something like a "ignore errors" option?
The text was updated successfully, but these errors were encountered: