Improve testing, run tests against production #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added note in readme for running tests on real network targets
kg6zvp
force-pushed
the
kg6zvp/improve-testing
branch
from
d982425
to
cfaf313
Compare
stephenlacy
suggested changes
May 10, 2019
| You can do so by adding the following to your `~/.bashrc`: | ||
|
|
||
| ```sh | ||
| export VANDELAY_UTIL_CONFIG="/home/gilbates/git/van-config/config.js" |
There was a problem hiding this comment.
what is with gilbates?
There was a problem hiding this comment.
I don't like adding files to the home directory (or anywhere outside the repo), having a .env in the repo folder file would be much easier
| if (responses.route) app.get(routeURL, wrap(responses.route)) | ||
| const bootstrapUtil = async (responses) => { | ||
| let port | ||
| let server |
There was a problem hiding this comment.
Don't use lets, server does not need to be a let, getPort() can return the port depending on the env.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleans up the creation and teardown of the mocks server for testing and allows executing test code against the production machines instead of the mocks server. This can be used for creating fixtures and configuring mocks more quickly and to ensure that the mocks are working correctly.
A note has also been added to the README to explain how to configure the bashrc to use this feature.