Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial skeleton #1

Merged
merged 22 commits into from
Mar 1, 2019
Merged

Add initial skeleton #1

merged 22 commits into from
Mar 1, 2019

Conversation

hamza3202
Copy link
Contributor

No description provided.

@stakater-user
Copy link
Contributor

@hamza3202 Yikes! You better fix it before anyone else finds out! Build 1 has Failed!

@stakater-user
Copy link
Contributor

@hamza3202 Yikes! You better fix it before anyone else finds out! Build 2 has Failed!

@stakater-user
Copy link
Contributor

@hamza3202 Yikes! You better fix it before anyone else finds out! Build 1 has Failed!

@stakater-user
Copy link
Contributor

@hamza3202 Yikes! You better fix it before anyone else finds out! Build 2 has Failed!

@stakater-user
Copy link
Contributor

@hamza3202 Yikes! You better fix it before anyone else finds out! Build 3 has Failed!

@stakater-user
Copy link
Contributor

@hamza3202 Yikes! You better fix it before anyone else finds out! Build 4 has Failed!

@stakater-user
Copy link
Contributor

@hamza3202 Yikes! You better fix it before anyone else finds out! Build 7 has Failed!

@stakater-user
Copy link
Contributor

@hamza3202 Yikes! You better fix it before anyone else finds out! Build 8 has Failed!

@stakater-user
Copy link
Contributor

@hamza3202 Yikes! You better fix it before anyone else finds out! Build 4 has Failed!

@stakater-user
Copy link
Contributor

@hamza3202 Image is available for testing. docker pull stakater/whitelister:PR-1-9

@stakater-user
Copy link
Contributor

@hamza3202 Image is available for testing. docker pull stakater/whitelister:PR-1-5

@rasheedamir
Copy link
Member

finally built! well done @hamza3202

@stakater-user
Copy link
Contributor

@hamza3202 Image is available for testing. docker pull stakater/whitelister:PR-1-10

@stakater-user
Copy link
Contributor

@hamza3202 Image is available for testing. docker pull stakater/whitelister:PR-1-6

@stakater-user
Copy link
Contributor

@hamza3202 Image is available for testing. docker pull stakater/whitelister:PR-1-11

For whitelister command and kube Ip Provider
@stakater-user
Copy link
Contributor

@hamza3202 Image is available for testing. docker pull stakater/whitelister:PR-1-12

@stakater-user
Copy link
Contributor

@hamza3202 Image is available for testing. docker pull stakater/whitelister:PR-1-7

glide.yaml Show resolved Hide resolved
internal/pkg/cmd/Whitelister.go Outdated Show resolved Hide resolved
}

services, err := clientset.Core().Services("").List(meta_v1.ListOptions{
LabelSelector: filter.LabelName + "=" + filter.LabelValue},

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use LabelSelector to generate the key value pairs for us. There can be more than 1 labels through which we might need to filter. So its better to make Filter a map[string]string
Then you can use this to generate the key value pairs for the LabelSelector

meta_v1.FormatLabelSelector(&meta_v1.LabelSelector{MatchLabels: filterLabels})

@stakater-user
Copy link
Contributor

@hamza3202 Image is available for testing. docker pull stakater/whitelister:PR-1-1

@stakater-user
Copy link
Contributor

@hamza3202 Image is available for testing. docker pull stakater/whitelister:PR-1-2

@stakater-user
Copy link
Contributor

@hamza3202 Yikes! You better fix it before anyone else finds out! Build 3 has Failed!

@stakater-user
Copy link
Contributor

@hamza3202 Yikes! You better fix it before anyone else finds out! Build 4 has Failed!

@stakater-user
Copy link
Contributor

@hamza3202 Image is available for testing. docker pull stakater/whitelister:PR-1-6

@stakater-user
Copy link
Contributor

@hamza3202 Yikes! You better fix it before anyone else finds out! Build 7 has Failed!

@stakater-user
Copy link
Contributor

@hamza3202 Yikes! You better fix it before anyone else finds out! Build 8 has Failed!

@stakater-user
Copy link
Contributor

@hamza3202 Yikes! You better fix it before anyone else finds out! Build 9 has Failed!

@stakater-user
Copy link
Contributor

@hamza3202 Image is available for testing. docker pull stakater/whitelister:PR-1-10

@stakater-user
Copy link
Contributor

@hamza3202 Image is available for testing. docker pull stakater/whitelister:PR-1-11

@stakater-user
Copy link
Contributor

@hamza3202 Image is available for testing. docker pull stakater/whitelister:PR-1-12

@stakater-user
Copy link
Contributor

@hamza3202 Image is available for testing. docker pull stakater/whitelister:PR-1-13

@stakater-user
Copy link
Contributor

@hamza3202 Image is available for testing. docker pull stakater/whitelister:PR-1-14

glide.yaml Show resolved Hide resolved
{{/*
Expand the name of the chart.
*/}}
{{- define "name" -}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add "whitelister-" before all these templates

@stakater-user
Copy link
Contributor

@hamza3202 Image is available for testing. docker pull stakater/whitelister:PR-1-15

@kahootali kahootali merged commit e1eae27 into master Mar 1, 2019
@kahootali kahootali deleted the initial branch March 1, 2019 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants