-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial skeleton #1
Conversation
@hamza3202 Yikes! You better fix it before anyone else finds out! Build 1 has Failed! |
@hamza3202 Yikes! You better fix it before anyone else finds out! Build 2 has Failed! |
@hamza3202 Yikes! You better fix it before anyone else finds out! Build 1 has Failed! |
@hamza3202 Yikes! You better fix it before anyone else finds out! Build 2 has Failed! |
@hamza3202 Yikes! You better fix it before anyone else finds out! Build 3 has Failed! |
@hamza3202 Yikes! You better fix it before anyone else finds out! Build 4 has Failed! |
@hamza3202 Yikes! You better fix it before anyone else finds out! Build 7 has Failed! |
@hamza3202 Yikes! You better fix it before anyone else finds out! Build 8 has Failed! |
@hamza3202 Yikes! You better fix it before anyone else finds out! Build 4 has Failed! |
@hamza3202 Image is available for testing. |
@hamza3202 Image is available for testing. |
finally built! well done @hamza3202 |
@hamza3202 Image is available for testing. |
@hamza3202 Image is available for testing. |
@hamza3202 Image is available for testing. |
For whitelister command and kube Ip Provider
@hamza3202 Image is available for testing. |
@hamza3202 Image is available for testing. |
} | ||
|
||
services, err := clientset.Core().Services("").List(meta_v1.ListOptions{ | ||
LabelSelector: filter.LabelName + "=" + filter.LabelValue}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should use LabelSelector to generate the key value pairs for us. There can be more than 1 labels through which we might need to filter. So its better to make Filter a map[string]string
Then you can use this to generate the key value pairs for the LabelSelector
meta_v1.FormatLabelSelector(&meta_v1.LabelSelector{MatchLabels: filterLabels})
@hamza3202 Image is available for testing. |
@hamza3202 Image is available for testing. |
@hamza3202 Yikes! You better fix it before anyone else finds out! Build 3 has Failed! |
@hamza3202 Yikes! You better fix it before anyone else finds out! Build 4 has Failed! |
@hamza3202 Image is available for testing. |
@hamza3202 Yikes! You better fix it before anyone else finds out! Build 7 has Failed! |
@hamza3202 Yikes! You better fix it before anyone else finds out! Build 8 has Failed! |
@hamza3202 Yikes! You better fix it before anyone else finds out! Build 9 has Failed! |
@hamza3202 Image is available for testing. |
@hamza3202 Image is available for testing. |
@hamza3202 Image is available for testing. |
@hamza3202 Image is available for testing. |
@hamza3202 Image is available for testing. |
{{/* | ||
Expand the name of the chart. | ||
*/}} | ||
{{- define "name" -}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add "whitelister-" before all these templates
@hamza3202 Image is available for testing. |
No description provided.