Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve enable conditions and use helpers.tpl #226

Merged
merged 28 commits into from
Mar 20, 2023
Merged

improve enable conditions and use helpers.tpl #226

merged 28 commits into from
Mar 20, 2023

Conversation

rasheedamir
Copy link
Member

@rasheedamir rasheedamir commented Mar 13, 2023 •
edited
Loading

This was referenced Mar 13, 2023
Closed
Closed
@github-actions
Copy link

github-actions bot commented Mar 14, 2023 •
edited
Loading

@mustafaStakater validation successful`

This was referenced Mar 15, 2023
Closed
Closed
rasheedamir
rasheedamir commented Mar 15, 2023
View reviewed changes
application/templates/_helpers.tpl Outdated
app.kubernetes.io/version: {{ include "application.version" . }}
app.kubernetes.io/managed-by: {{ .Release.Service }}
app.kubernetes.io/component: {{ include "application.name" . }}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mustafaStakater if someone isn't using argocd then what will happen?

Copy link
Contributor

@mustafaStakater mustafaStakater Mar 16, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it shouldnt cause a conflict in that case i left part-of label for users to identify what application is the resource part of

@mustafaStakater mustafaStakater merged commit ecc11c7 into master Mar 20, 2023
@mustafaStakater mustafaStakater deleted the major-refactoring branch March 20, 2023 11:23
This was referenced Mar 20, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mustafaStakater mustafaStakater mustafaStakater approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rasheedamir @mustafaStakater @hussnain612