Prepare solution for publication on NuGet #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new MSBuild-based project file format will allow us to easily build a NuGet package without having to maintain a separate `.nuspec` so let's upgrade.
Up until now, the rationale for having two separate projects was that `stakx.WIC.Interop` contained only COM interop type declarations which could be fully embedded into consumer assemblies using "Embed Interop Types". Now that we're going to distribute this library as a NuGet package, embedding interop types is probably no longer an essential feature. Keeping this feature intact would require an `install.ps1` script that adjusts the "Embed Interop Types" flag in the consumer project, which is not very nice. In conclusion, while combining the projects isn't nice from a techni- cal point of view, it is probably more convenient, all things con- sidered.
It turned out that unit testing COM interop type definitions is rather difficult (or even pointless): there isn't much program logic worth testing in `stakx.WIC` itself, so let's remove the unit test project. It might be added back later on when we have some actual logic (i.e. that dealing with processing image metadata).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This encompasses the following steps:
stakx.WIC.Interopintostakx.WIC.stakx.WIC.Interop.Tests.