Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added some sample code and PixelFormat constants #8

Merged
merged 3 commits into from
Jun 29, 2019
Merged

Added some sample code and PixelFormat constants #8

merged 3 commits into from
Jun 29, 2019

Conversation

jpmikkers
Copy link
Contributor

No description provided.

stakx
stakx requested changes Jun 29, 2019
View reviewed changes
Copy link
Owner

@stakx stakx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the PR! 👍 I'll be very happy to merge your contributions, just two small suggestions regarding code convention consistency.

WIC/Constants/WICPixelFormats.cs Outdated Show resolved Hide resolved
WIC/Constants/WICPixelFormats.cs Outdated Show resolved Hide resolved
@jpmikkers
Copy link
Contributor Author

Done!

@stakx stakx merged commit f9ae87f into stakx:develop Jun 29, 2019
@stakx
Copy link
Owner

stakx commented Jun 29, 2019

Wonderful, thank you!

Now that the source code is no longer just by me, I'll probably need to update the copyright in the license file.

Let me know if you'd like me to push an updated package to NuGet.

@jpmikkers
Copy link
Contributor Author

Hi stakx, no that's not necessary, I barely touched the library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stakx stakx stakx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpmikkers @stakx