-
Notifications
You must be signed in to change notification settings - Fork 11
Translated Hello World page #2
Translated Hello World page #2
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this file is used anymore
Great work! I haven't had the chance to run this yet and look at the live version, but from what I've seen it should be fine. Take a look at the comments and the change request and we can go ahead and merge this 🙂 |
@nsadev This is how the live version looks if you haven't gotten your environment up yet 🙂 |
Thanks for spotting the things needing correction @rloqvist, was a bit unsure if without hyphen was right. Have corrected it all and updated. Also thank you for the screenshot, great to see! Hope to get some time this weekend to take a better look at the problem with Gatsby to get the site visible. |
Nice! Could you remove the file |
Sorry, didn't see it in the file tree. How do I create a commit @rloqvist when there's only a deleted file that's changed, add it as usual or something else? Edit: found these two, could one of them be the solution? |
That depends on what |
@rloqvist all ok with the latest? |
* Added documentation for React.createFactory * Update beta/src/content/apis/react/createFactory.md Co-authored-by: Strek <ssharishkumar@gmail.com> * minor editorial updates (#2) * Update createFactory.md * Update createFactory.md * edits Co-authored-by: Strek <ssharishkumar@gmail.com> Co-authored-by: Holly Sweeney <77758406+holly1238@users.noreply.github.com> Co-authored-by: Dan Abramov <dan.abramov@gmail.com>
Hope everything works as it should, let me know if any changes are needed.
@tesseralis @rloqvist