Skip to content
This repository has been archived by the owner on Apr 21, 2023. It is now read-only.

Translated Hello World page #2

Merged
merged 4 commits into from
May 13, 2019

Conversation

nsadev
Copy link
Contributor

@nsadev nsadev commented May 8, 2019

Hope everything works as it should, let me know if any changes are needed.

@tesseralis @rloqvist

Copy link
Contributor

@rloqvist rloqvist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this file is used anymore

@rloqvist
Copy link
Contributor

Great work! I haven't had the chance to run this yet and look at the live version, but from what I've seen it should be fine. Take a look at the comments and the change request and we can go ahead and merge this 🙂

@rloqvist
Copy link
Contributor

@nsadev This is how the live version looks if you haven't gotten your environment up yet 🙂

hello-world-translate

@nsadev
Copy link
Contributor Author

nsadev commented May 10, 2019

Thanks for spotting the things needing correction @rloqvist, was a bit unsure if without hyphen was right. Have corrected it all and updated.

Also thank you for the screenshot, great to see! Hope to get some time this weekend to take a better look at the problem with Gatsby to get the site visible.

@rloqvist
Copy link
Contributor

rloqvist commented May 10, 2019

Nice! Could you remove the file hej-varlden.md aswell 🙂

@nsadev
Copy link
Contributor Author

nsadev commented May 10, 2019

Sorry, didn't see it in the file tree. How do I create a commit @rloqvist when there's only a deleted file that's changed, add it as usual or something else?

Edit: found these two, could one of them be the solution?
git ls-files --deleted -z | xargs -0 git rm
git diff --name-only --diff-filter=D -z | xargs -0 git rm --cached

@rloqvist
Copy link
Contributor

That depends on what git status yields. If it shows that you deleted the file you can make a commit and push it.

@nsadev
Copy link
Contributor Author

nsadev commented May 13, 2019

@rloqvist all ok with the latest?

@rloqvist rloqvist merged commit 42a2741 into stale-reactjs-org-translations:master May 13, 2019
@nsadev nsadev deleted the HelloW branch May 24, 2019 08:38
@tesseralis tesseralis mentioned this pull request Jun 18, 2019
88 tasks
react-translations-bot pushed a commit that referenced this pull request Oct 10, 2022
* Added documentation for React.createFactory

* Update beta/src/content/apis/react/createFactory.md

Co-authored-by: Strek <ssharishkumar@gmail.com>

* minor editorial updates (#2)

* Update createFactory.md

* Update createFactory.md

* edits

Co-authored-by: Strek <ssharishkumar@gmail.com>
Co-authored-by: Holly Sweeney <77758406+holly1238@users.noreply.github.com>
Co-authored-by: Dan Abramov <dan.abramov@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants