fixed static port 801 #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stamp
requested changes
Nov 10, 2021
main.go
Outdated
| @@ -80,7 +76,7 @@ func (conn *Connection) Connect() { | |||
| logger.Trace("Connected") | |||
| conn.shutdown = make(chan bool) | |||
| conn.shutdownFinal = make(chan bool) | |||
|
|
|||
| conn.target = stringToNetId(conn.netid) | |||
| conn.target.port = 801 | |||
There was a problem hiding this comment.
Could it be that we need to update 801 to port as well?
There was a problem hiding this comment.
You are right. I replaced that as well with a new commit.
I tested it on a separate system and forgot to take both changes into the repo on my development machine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the port 801 is fixed and cannot be changed.
This is problematic especially because TwinCAT3 uses port 851 per default for PLC.
Beside that I also used uint16 for port variable because this is sufficient.