Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert a draws_list to a draws_df #51

Closed
MansMeg opened this issue Nov 15, 2019 · 3 comments
Closed

Convert a draws_list to a draws_df #51

MansMeg opened this issue Nov 15, 2019 · 3 comments
Labels
bug Something isn't working
Milestone

Comments

@MansMeg
Copy link
Collaborator

MansMeg commented Nov 15, 2019

> class(x)
[1] "pdb_gold_standard_draws" "draws_list"              "draws"                  
[4] "list"                   
> posterior::as_draws_df(x)
Error in class(out) <- class_draws_df() : 
  attempt to set an attribute on NULL
>   xdf <- posterior::as_draws_matrix(x)
Error in class(out) <- class_draws_df() : 
  attempt to set an attribute on NULL
> packageVersion("posterior")
[1] ‘0.0.1’
@MansMeg MansMeg added the bug Something isn't working label Nov 15, 2019
paul-buerkner added a commit that referenced this issue Nov 15, 2019
@paul-buerkner paul-buerkner added this to the beta release milestone Nov 15, 2019
@paul-buerkner
Copy link
Collaborator

Thanks! Should be fixed now.

@jgabry
Copy link
Member

jgabry commented Nov 15, 2019

Thanks for fixing. I think it would be good to add a test when fixing things like this so we make sure it still works as we continue to change the functions in the package.

@paul-buerkner
Copy link
Collaborator

paul-buerkner commented Nov 15, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants