-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt to new posterior database structure #14
Conversation
The problem with this solution is that we no longer have access to the data names and model names from po$data_name <- po$data
po$model_name <- po$data to This is maybe not the best solution still though |
Another way would be not to overwrite A third way would be to not attach the info file contents to would become something like model_info <- load_model_info(x$model)
mcfp <- file.path(x$pdb$path, model_info[[framework]]) |
Now this PR doesn't overwrite anything. The slots in the posterior object are now
|
This should include everything that is needed now. I think you haven't added the contributor etc slots yet so I couldn't include them here. Would be great if you can first merge this and then add the new slots |
json file inside them had name with lowercase n instead of capital N, which meant that R package couldn't find them
I found a problem in master branch that was causing tests to fail, some dataset zip files had json files inside them with wrong filename (lowercase n instead of capital N) that caused |
Great! I had problem finding that problem yesterday. |
This pull request changes to new posterior database structure and adapts rpackage to the new structure.
Fixes #8