Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compilation under rstan 2.26 #510

Closed
wants to merge 1 commit into from
Closed

Fix compilation under rstan 2.26 #510

wants to merge 1 commit into from

Conversation

andrjohns
Copy link
Contributor

This PR adds Makevars flags needed to build rstanarm against the new 2.26 version of rstan

@andrjohns andrjohns mentioned this pull request Apr 24, 2021
Open
@jgabry
Copy link
Member

jgabry commented May 7, 2021

Thanks @andrjohns! Will this now only work with 2.26 or will it still also work fine with older versions?

@andrjohns
Copy link
Contributor Author

Looks like I missed a comment from @hsbadr on this! This flag should only be defined if the associated rstan version is >= 2.26. (that comment here). So this flag should be conditionally included using if (utils::packageVersion("rstan") >= 2.26). I'll have a look into fixing this up

@jgabry
Copy link
Member

jgabry commented May 8, 2021

Ok great thanks!

@andrjohns
Copy link
Contributor Author

Superseded by #574

@andrjohns andrjohns closed this Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sambrilleman sambrilleman Awaiting requested review from sambrilleman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrjohns @jgabry