Use | instead of || for or condition #594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes introduced in R>=4.3 mean that the `||` operator returns an error when it is used to evaluate an or condition for a length > 1 vector. The fix here is to use the vectorised form - `|` - instead (which probably should have been used in the first place...).
sambrilleman
added
bug
survival
sambrilleman
added a commit
that referenced
this pull request
Nov 5, 2023
Same as #594. But must have missed the use of it in log_lik.R
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes introduced in R>=4.3 mean that the
||operator returns an error when it is used to evaluate an or condition for a length > 1 vector. The fix here is to instead use the vectorised form,|(which probably should have been used in the first place...).Fixes #593.