Rollback JSOO version for QuickJS compatibility #1427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are we also pursuing a fix in quickjs? I don't want to have a version pinning here which is stuck indefinitely because another package doesn't correctly implement part of javascript |
They've said that they're aware of the bug, so I guess so. It's easy enough to revisit later if there's a compelling reason to upgrade |
WardBrian
reviewed
May 21, 2024
| @@ -3,7 +3,9 @@ | |||
| # exit when any command fails | |||
| set -e | |||
|
|
|||
| opam pin -y js_of_ocaml 5.5.2 | |||
| # JSOO versions higher than this break QuickJS (labelled break statements) | |||
There was a problem hiding this comment.
Can we link to either (or both) of the stanc/quickjs issues in this comment, just to make said future testing easier
26 tasks
WardBrian
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submission Checklist
Closes #1425
Release notes
Rollback js_of_ocaml to 5.4.0 for compatibility with QuickJS
Copyright and Licensing
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the BSD 3-clause license (https://opensource.org/licenses/BSD-3-Clause)