Update dependencies #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajcspsg
commented
May 26, 2021
| case TimeUnit.DAYS => JavaDuration.ofDays(duration.length) | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
I copied this from https://github.com/scala/scala-java8-compat/blob/main/src/main/scala/scala/compat/java8/DurationConverters.scala. I don't want to include another dependency.
There was a problem hiding this comment.
I am thinking, this update is bringing some new major versions of dependencies. So we are already potentially breaking compatibility for some downstream code. Why not just switch to the Java Duration and bump the major version of reftree?
There was a problem hiding this comment.
okay I will switch to java Duration.
There was a problem hiding this comment.
updated to use java duration
stanch
reviewed
May 26, 2021
| } | ||
| stream.finish() | ||
| // stream.finish() |
There was a problem hiding this comment.
I will remove this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.