Add stream merger, separator directives #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #68 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 18 19 +1
Lines 1073 1114 +41
Branches 244 252 +8
=====================================
+ Hits 1073 1114 +41
Continue to review full report at Codecov.
|
standage
commented
Jun 14, 2019
| @@ -108,3 +106,13 @@ def test_sum(capsys): | |||
|
|
|||
| out, err = capsys.readouterr() | |||
| assert out.strip() == tag.pkgdata('sum-test-out.txt').read().strip() | |||
|
|
|||
|
|
|||
| def test_merge(capfd): | |||
There was a problem hiding this comment.
There's some capsys/capfd weirdness that needs to be sorted out. May as well drop the whole logging crap as it seems to create a lot of problems with capturing testing output.
standage
changed the title
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update introduces a couple new changes: a new
tag.select.mergefunction for efficient merging of multiple sorted streams into a single stream; and a modification to theGFF3Writerclass so that it will intermittently output separator directives in long stretches of simple (childless) features.