Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extensive refactoring of Score and Feature constructor API #74

Merged
merged 2 commits into from
Jun 27, 2019

Conversation

standage
Copy link
Owner

@standage standage commented Jun 27, 2019

The original Feature constructor was optimized for instantiating objects from GFF3 data. Static factory constructor methods were duct taped on later, but after using these for a while it's clear things are backwards. This update changes the API so that the default constructor requires a sequence identifier, feature type, and genomic coordinates. The static method create has been dropped and the static method from_gff3 has been added. Various other getter/setter methods were updated, and the API of the Score class was also updated.

  • Full test coverage? Any additional tests that could easily be added?
  • API documentation up-to-date? Docstring examples?
  • Is the CHANGELOG up-to-date?

@codecov-io
Copy link

codecov-io commented Jun 27, 2019

Codecov Report

Merging #74 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #74   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          23     23           
  Lines        1281   1269   -12     
  Branches      287    290    +3     
=====================================
- Hits         1281   1269   -12
Impacted Files Coverage Δ
tag/__init__.py 100% <ø> (ø) ⬆️
tag/feature.py 100% <100%> (ø) ⬆️
tag/reader.py 100% <100%> (ø) ⬆️
tag/locus.py 100% <100%> (ø) ⬆️
tag/score.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bd6e2d...cf9be22. Read the comment docs.

@standage standage merged commit 36c1a9b into master Jun 27, 2019
@standage standage deleted the refactor/feature branch June 27, 2019 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants