Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Parent attribute handling for features with multiple parents #85

Merged
merged 3 commits into from
Oct 21, 2020

Conversation

standage
Copy link
Owner

@standage standage commented Oct 21, 2020

The solution to #84 was pretty simple: adding append=True to the child's Parent reset logic when a feature's ID is updated.

Evaluating a new failure in the test suite revealed an error in one of the test data files. This error has also be corrected.

Fixes #84.

  • Full test coverage? Any additional tests that could easily be added?
  • API documentation up-to-date? Docstring examples?
  • Is the CHANGELOG up-to-date?

@codecov
Copy link

codecov bot commented Oct 21, 2020

Codecov Report

Merging #85 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #85   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           25        25           
  Lines         1423      1422    -1     
  Branches       313       313           
=========================================
- Hits          1423      1422    -1     
Impacted Files Coverage Δ
tag/feature.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a107d27...aef1279. Read the comment docs.

@standage standage merged commit 9447ba8 into master Oct 21, 2020
@standage standage deleted the fix/multiparent branch October 21, 2020 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error handling Parent attribute for features with multiple parents
1 participant