Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump MSRV to 1.70 #39

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Bump MSRV to 1.70 #39

wants to merge 2 commits into from

Conversation

simonsso
Copy link
Contributor

Update frozen dependencies

@simonsso simonsso changed the title Cargo update Update dependencies and increase MSRV to 1.65 Feb 14, 2024
@simonsso
MSRV increased to 1.70
0bfc29a 
Dependecy package `regex-automata v0.4.5` requires rustc 1.65 or newer,
                  `time v0.3.34` requires rustc 1.67.0 or newer,
                  `tracing-tree v0.2.5` requires rustc 1.70 or newer
@simonsso simonsso changed the title Update dependencies and increase MSRV to 1.65 Update dependencies and increase MSRV to 1.70 Feb 14, 2024
@simonsso simonsso changed the title Update dependencies and increase MSRV to 1.70 Bump MSRV to 1.70 Feb 15, 2024
@simonsso simonsso mentioned this pull request Feb 22, 2024
Merged
@rnarubin
Copy link
Collaborator

What's the motivation for the updates? Updating a dependency makes sense if we need new functionality for a code change; or updating to avoid a yanked version. However a crate-wide update for its own sake isn't necessarily an improvement -- I value CI stability more than dependency recency.

@rnarubin rnarubin self-assigned this Feb 23, 2024
@simonsso
Copy link
Contributor Author

What's the motivation for the updates? Updating a dependency makes sense if we need new functionality for a code change; or updating to avoid a yanked version. However a crate-wide update for its own sake isn't necessarily an improvement -- I value CI stability more than dependency recency.

This started as a dependabot warning on my project.

@simonsso
Copy link
Contributor Author

@rnarubin are you maintaining this repo in some way or is it only @maroux? @maroux has been AFK for over a month now.

@rnarubin
Copy link
Collaborator

@rnarubin are you maintaining this repo in some way or is it only @maroux? @maroux has been AFK for over a month now.

I maintain this repo. Maroux is an administrator of our top-level github org, but is otherwise not much involved in this particular codebase.

This started as a dependabot warning on my project

Can you share the warning message reported by dependabot please. If there is some dependency with a known risk then upgrading it is alright (i.e. targeted updates of specific risks)

@simonsso
Copy link
Contributor Author

I maintain this repo. Maroux is an administrator of our top-level github org, but is otherwise not much involved in this particular codebase.

Thanks, I was worried this was unmaintained when I saw only one person listed on the organisation.

@rnarubin
Copy link
Collaborator

Do you have the dependabot warning you can share? I'm curious what it considers a concern

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rnarubin rnarubin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simonsso @rnarubin