-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should it wait all statuses to finish before release? #10
Comments
I believe changing it to statuses.data.forEach((x) => {
const isCIStatus = /(?:travis-ci|circleci)/.test(x.context)
const isPending = x.state === 'pending'
const isPassing = x.state === 'success'
if (isPending && isCIStatus && !cache.pending.includes(x.context)) {
cache.pending.push(x.context)
}
if (isPassing && isCIStatus && !cache.passed.includes(x.context)) {
cache.passed.push(x.context)
}
}) would be enough |
Signed-off-by: Charlike Mike Reagent <olsten.larck@gmail.com>
@olstenlarck I think you would only want to release after status all pass. In the case of So, if a status is required (it can fail) then a release should wait on it. |
Yea, but i'm not sure if status object from the api has such thing as "isRequired". Also it's a good thing to do all that in CI. Just add jobs that calls tests and other similiar checks as bitHound on the CI, so we can only check of CI passes. Makes things a lot easier. Personally i like it that way. Also bitHound and such services may take very long time. Time that i don't have while constantly developing and updating and releasing new versions of my packages. Actually packages that builds that whole thing - detect-new-version, parse-commit-message, new-release, execa-pro and etc. Once all is much stable, we can switch to check all statuses or add option for that through configuration file. |
@olstenlarck maybe consider adding a configuration option to set required status checks? Renovate does something similar prior to auto-accepting pull requests - https://renovateapp.com/docs/configuration-reference/configuration-options#requiredstatuschecks |
Yup, it's in the roadmap. |
Also... the the lint issue is actually intentional eslint warning, for |
Or it is enough to wait only CI services to end.
Talking about that part
https://github.com/tunnckoCore/semantic-release-app/blob/0bbf1731584d69ab00d5bfc42241c9190e51ec39/src/index.js#L97-L106
I really i lost few hours today before i realized why it does not publish releases, just because of that ;d
Initially i was thinking about it and decide that it is good thing to wait everything to finish, but for example bitHound is slow, so publishing release may appear with delay of 5+ minutes in some cases.
/cc @gr2m
The text was updated successfully, but these errors were encountered: