Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused eslint-plugin-standard peerDep #35

Closed
wants to merge 3 commits into from
Closed

Remove unused eslint-plugin-standard peerDep #35

wants to merge 3 commits into from

Conversation

hoobdeebla
Copy link

@hoobdeebla hoobdeebla commented Feb 3, 2021

This PR does the following:

  1. Removes the outdated and unused eslint-plugin-standard peerDependency
  2. Makes peerDeps use ^ operator instead of >= as has already been done for other standard repos - requires bumping peerDeps more often but prevents upstream breaking changes from affecting users
  3. Syncs the package.json metadata fields with their standard/eslint-config-standard equivalents

@welcome
Copy link

welcome bot commented Feb 3, 2021

🙌 Thanks for opening this pull request! You're awesome.

@vladimyr
Copy link
Contributor

vladimyr commented Feb 3, 2021

How about making it into 2 or even 3 PRs so we don't have such a huge diff?

  1. What is the reasoning behind removing install-peerdeps installation shortcut?
  2. package.json test field is used for declaring test command/s, not for the whole CI pipeline

My main problem with this is that you joined together a bunch of non-essential stuff with essential peer dependencies version updates. Former should be addressed through multiple unrelated PRs where points like those two I just listed could/should be addressed while latter could land in as quickly as possible without any discussion needed...

Copy link
Contributor

@vladimyr vladimyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't get me wrong it really warms my heart seeing people giving some love to this and other projects. Sincere kudos for doing that and don't let my tone turn you down from keep doing it! 🏆

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@hoobdeebla hoobdeebla changed the title Remove unused eslint-plugin-standard peerDep, update readme Remove unused eslint-plugin-standard peerDep Feb 3, 2021
@voxpelli
Copy link
Member

I took quite a bit of inspiration as I modernized this module in preparation for releasing a new version of semistandard.

Much of this one is released in version 16.0.0, and I gave you credit in the release notes: https://github.com/standard/eslint-config-semistandard/releases/tag/v16.0.0

Thanks!

@voxpelli voxpelli closed this Jun 14, 2021
@hoobdeebla hoobdeebla deleted the fix-peerdeps branch August 13, 2021 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants