-
-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop the jsx-quotes eslint rule #40
Comments
I have neither the interest nor the energy to debate this all over again. I don't even care anymore. You obviously have stronger feelings about this than I do at this point, so feel free to do whatever you want. If you think syntactic purity is more important, whatever. I'm having a hard enough time defending standard as it is. I'm not interested in debating other standard users too. Just keep me of out of this and address the actual arguments so other people have a fair chance to have a discussion. |
@askmatey Drop the attitude. No need for it. |
@askmatey Please be civil. We're all volunteers here, just doing our best. There's no need to be so aggressive. You're the first person to raise this objection since the v8 beta. I'll keep my eyes open to any further objections before the v8 release. I don't think that most people feel very strongly about the change. And since it's fixable with |
1 similar comment
@askmatey Please be civil. We're all volunteers here, just doing our best. There's no need to be so aggressive. You're the first person to raise this objection since the v8 beta. I'll keep my eyes open to any further objections before the v8 release. I don't think that most people feel very strongly about the change. And since it's fixable with |
Please don't get me wrong @feross. The debate amongst developers on whether one should use double quotes or single quotes in ECMAScript has been around for ages. You know it. And with standard you have developed a solution. The rules form the basis. But there should be no exception to the norm by default, especially when there's no obvious reason - like using double quotes for JSX.
Yes, I think so @pluma. Again, JSX is not intended to incorporate with the HTML spec. And let's take it the other way around: The HTML spec itself says, that single and double quotes are interchangeable, there is no difference
https://www.w3.org/TR/html4/intro/sgmltut.html#h-3.2.2
Excuse me, this is not a safe space @joshmanders |
Has nothing to do with safe spaces and all to do with you being a dick. You can get your point across without the latter. |
@askmatey neither the community nor the maintainers owe you (nor anyone else for that matter) any attention or affordances. I suggest you adjust your tone. There may be a worthwhile discussion here but it's not going to happen if you're being disrespectful and hostile. |
Continue discussion in #27 (with which, this is a duplicate anyway), this thread doesn't appear to be constructive. |
I am the originator of the idea to split the react and jsx eslint rules into separate packages.
The
jsx-quotes
eslint rule should be entireley dropped.The rule is bloat here. The suggested enforcement to use double quotes in the upcoming release #564 inevitably results in an infringement of the »single quotes for strings« rule.
Following #27 , some comments
Excuse me, Sir. What majority are you talking about @pluma? Have you shown us some evidence or are you simply using your superior GitHub reputation as an argument? And no, you are wrong.
Wew. Here we go again: JSX is intended to be used by various preprocessors (transpilers) to transform DOM tokens into standard ECMAScript and that's it. Nothing more. It's not a proposal to incorporate with the HTML spec itself.
I am sorry @dverbru. Is this some exclusive club you are talking about? Again: JSX is not restricted to only one framework.
You are making up a big story here @pluma. Who or what is AirBnB and why is it important here? This is not a beauty competition. This project is about coding-style. Some people prefer single quotes, others double quotes. Some prefer spicy meatballs over tendies.
But here's the good news: The original idea of standard was to define a common, simplified coding standard, based on a few simple rules. Very simple rules. @feross made it as simple as it gets.
And the rule states to use single quotes. Point. That's it. And if you have trouble to use double and single quotes in one string, you are always welcome to use template literals. And please don't worry. The preprocessor will take care of it.
Everyone is free to define his prefered configuration, I see no reason to include this rule by default.
The text was updated successfully, but these errors were encountered: