Stop package.json settings from overriding explicit options #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for digging into this. It's been a while since I looked at this code. I think the right behavior is to continue merging the settings. The only setting where that's not possible is |
feross
added a commit
that referenced
this pull request
Jan 13, 2017
Fixes: #141 Explanation: #146 (comment)
|
PR sent: #154 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #141.
This would be a breaking change. Contrary to #134 (comment) though I'm only now (after writing the code) noticing that
globals,pluginsandenvsare concatenated onto the existing values. So perhaps this isn't a problem at all?If this is merged after all, note that I'm assuming #135 has landed, since it would allow implementors to write their own option merging logic.