-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for standard-engine@15
#376
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what I can see, this looks pretty good. 👍
Thank you very much for taking this task.
(I did a new a commit to fix some linting issues)
It even works with top-level await support:
Few things before merging:
- Add a new automated test inside
client/testFixture
to teststandard@17.0.0-2
to avoid regression. - Investigate what happens if we for example use top-level await while using
standard@16
(without ESLint v8 support hence not supporting top-level await), the extension should not crash.
Not sure how to approach this one...
I tested both standard@latest and standard@next (globally), both working as expected, including erroring on unsupported syntax. @divlo if you point me in the right direction, I'll be glad to update this PR with anything necessary to merge it. |
To be honest, I don't know either, I don't affect this code too often. As the original maintainer of this repo doesn't maintain it anymore, I decided to maintain it, but most of the code has been written by the original maintainer. About the integration test part, yes indeed, that could be a little bit harder than I thought. Whether we succeed or not to do that new integration test, it is definitely non-blocking for merging this PR.
Great, you already did a really good job, I also tested it myself, and indeed, everything is working fine. 👍 @NemoStein Feel free to give ideas about how can we do integration testing for this VSCode extension. |
standard-engine@15
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[ ] Bug fix
[X] New feature
[ ] Other, please explain:
What changes did you make? (Give an overview)
Added support for Standard 17
Which issue (if any) does this pull request address?
#375
Is there anything you'd like reviewers to focus on?