replace_parameters: fix accessing arg if there is no primitive #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we're replacing inside the filter of a join, there is no current primitive (because can come from either primitive), so "slot.primitive" is null. Instead, we can access the argument directly from the slot. Use either the soon-to-be-added public "arg" property of the slot, or the private "_arg" property, and fall back to trying the prim anyway if we have one.
gcampax
added a commit
that referenced
this pull request
Jun 23, 2020
Update uuid to the latest version 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we're replacing inside the filter of a join, there is no
current primitive (because can come from either primitive), so
"slot.primitive" is null.
Instead, we can access the argument directly from the slot.
Use either the soon-to-be-added public "arg" property of the slot,
or the private "_arg" property, and fall back to trying the prim
anyway if we have one.
Fixes #111