Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix arguments after adding -url #872

Merged
merged 2 commits into from
Feb 10, 2022
Merged

Fix arguments after adding -url #872

merged 2 commits into from
Feb 10, 2022

Conversation

Mehrad0711
Copy link
Member

@Mehrad0711 Mehrad0711 commented Jan 31, 2022 •
edited
Loading

Fix bug introduced in 711dfb9

@Mehrad0711 Mehrad0711 force-pushed the wip/mehrad/fixes branch 4 times, most recently from ea96cf4 to 8892503 Compare February 8, 2022 22:27
@Mehrad0711
Copy link
Member Author

@rayslxu same test is failing on master too. Should we fix that first?

@sileix
Copy link
Member

sileix commented Feb 10, 2022

@rayslxu same test is failing on master too. Should we fix that first?

It's fixed now.

@Mehrad0711 Mehrad0711 merged commit 7d119ae into master Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sileix sileix sileix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mehrad0711 @sileix