Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching from Xalan to a secure alternative #1302

Open
e-reznik opened this issue Sep 13, 2022 · 8 comments
Open

Switching from Xalan to a secure alternative #1302

e-reznik opened this issue Sep 13, 2022 · 8 comments

Comments

@e-reznik
Copy link

e-reznik commented Sep 13, 2022

Core NLP uses xalan:xalan in the latest version as a dependency, which has several known vulnerabilities. As this project is deprecated, no fix will be provided.

It is advisable, to switch to an alternative, that is still being maintained. An alternative is Saxon XSLT, as it seems to be the successor of the Xalan project.

@e-reznik e-reznik changed the title Switching from Xalan to close vulnerability Switching from Xalan to a secure alternative Sep 13, 2022
@Afrina-Alam
Copy link

Any Update team on this ..?? This is critical from vulnerabilities perspective

@AngledLuffa
Copy link
Contributor

Is this because of xom? I don't think we use xalan directly.

[john@localhost CoreNLP]$ find src -name "*java" -exec grep -H --ignore-case "xalan" "{}" ";"
[john@localhost CoreNLP]$

If so, please see: #1264

I hope to make a new release end of next week or start of the week after. There are a couple other changes I need to discuss with my PI, and I don't think we'll meet until then. In the meantime, you can compile from the dev branch if this is critical

@Afrina-Alam
Copy link

Afrina-Alam commented Jan 11, 2023 via email

@AngledLuffa
Copy link
Contributor

4.5.2 now has an updated xom dependency. Would you check that it meets your needs?

@e-reznik
Copy link
Author

After reading those comments, I excluded xalan from my dependency. Not it's not showing anymore.

@kterusaki
Copy link

seems like xalan is still being included as a dependency in xom 1.3.8. xom released 1.3.9 which removes the xalan dependency entirely. Please update to xom 1.3.9

@AngledLuffa
Copy link
Contributor

This is already a thing in our dev branch:

c8772b7

We will make a new release with the update in a few weeks. There is some cleanup work to be done on a previous project which used CoreNLP that we want to release at the same time

@AngledLuffa AngledLuffa reopened this Jun 23, 2023
@AngledLuffa
Copy link
Contributor

They wound up releasing a new Xalan a few months back, and we found that there was something specifically in SUTime which expected XSLT, so we just kept it with the bugfix version of Xalan for the latest CoreNLP release. If this is still unsatisfactory, please let us know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants