bug(dspy): removed extra params from kwargs sent to vllm pydantic model

[omkar-sh]

Can you just checkout and suggest any changes?

[DamianB-BitFlipper]

Hi Omkar. I highly recommend using the dict pop method. It will make the code much simpler.

[omkar-sh]

Hi Damian, Made the changes with the pop method.

[DamianB-BitFlipper]

Hey. I would recommend using a default value of None. It is more pythonic than the string "False".

[DamianB-BitFlipper]

Also, a comment explaining why you do the pop in the first place would help. Possibly link the issue #974 in the comment.

[omkar-sh]

I made these changes.

[DamianB-BitFlipper]

Sorry for the constant nits, but could you please add a space between the , and the None. Thanks.

[omkar-sh]

Pushed the changes. Thanks

[DamianB-BitFlipper]

This looks good to me!

[arnavsinghvi11]

Thanks @omkar-sh ! made the small change of removing the comments mentioning the issue request.

[LorenzoMinto]

If system_prompt is not None it will also cause this issue . Added a PR to remove that from the kwargs as well.

[Wolfsauge]

@LorenzoMinto Thanks for mentioning that. I will follow up below the PR linked.