Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mlc-llm): fix mlc-llm ChatModuleClient with MLCEngine #1285

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

zhaohan-dong
Copy link
Contributor

Fix on issue #1206.
Both mlc_chat and ChatModule are depreciated. Replaced with MLCEngine which will be suppoorted going forward.
A few considerations:

  • Renaming the class to reflect the change from ChatModule
  • Use EngineConfig when setting up the MLCEngine to have more control over configuration

@arnavsinghvi11
Copy link
Collaborator

Thanks @zhaohan-dong !

@arnavsinghvi11 arnavsinghvi11 merged commit 950cbe4 into stanfordnlp:main Aug 2, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants