[g4star] Miscellaneous updates to StarAgmlLib #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plexoos
reviewed
May 26, 2022
|
... will take a stab at requested changes shortly... |
plexoos
reviewed
Jun 2, 2022
plexoos
reviewed
Aug 8, 2022
framework information to be attached to TGeoVolumes. The VMC framework utlizes the "framework" extensions, so we will utilize the "user" extensions in AgML. - Attach user-defined hit scoring functions to sensitive volumes. When the MC application's hit scoring is invoked in a given volume, the general hit scoring function can invoke any user functions stored on the volume. - Store the number of volume branchings for each volume, allowing us to define a unique volume ID to each volume defined within an AgML module.
AgMath provides math functions used by AgML codes. A few of these are functions defined in FORtran. A few defines have been made to prevent AgML variables from being mistaken for c-math routines.
enabled under ROOT5.
which connect user codes and volume IDs from the AgML source code to the TGeo geometry model.
here b/c AgML would not be filling / creating null entries. Plus... it should be safe to delete a nullptr...
plexoos
force-pushed
the
star-geant4star-starvmc-staragmllib
branch
from
faceedb
to
f098c2c
Compare
plexoos
approved these changes
Aug 24, 2022
|
There are no unresolved conversations and all checks have passed. We can merge if there are no further comments. |
|
@klendathu2k OK to merge? |
|
Ping @klendathu2k |
Yes, good to merge. |
plexoos
changed the title
|
Yes. Merge away.
…On 2022-08-25 11:04, Dmitri Smirnov wrote:
@klendathu2k [1] OK to merge?
--
Reply to this email directly, view it on GitHub [2], or unsubscribe
[3].
You are receiving this because you were mentioned.Message ID:
***@***.***>
Links:
------
[1] https://github.com/klendathu2k
[2]
#308 (comment)
[3]
https://github.com/notifications/unsubscribe-auth/ANL4LVETY6AOKUFYRXADTEDV26DRBANCNFSM5OV3DOHQ
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging StarAgmlLib which are independent of changes to
the StGeant4Maker development.
Brings code up to commit
71921c9
The changes represented in the next commit appears to have already been integrated.
7dcbd58
Beyond that commit (starting with 4c5edb1),
changes to StarAgmlLib are coupled to changes introduced in the StGeant4Maker/
directory.