Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable shared linking of mysqlclient lib to root4stat #346

Merged
merged 1 commit into from
May 12, 2022
Merged

Enable shared linking of mysqlclient lib to root4stat #346

merged 1 commit into from
May 12, 2022

Conversation

plexoos
Copy link
Member

@plexoos plexoos commented May 6, 2022

An alternative solution to the issue described in PR #343

@plexoos
cons: Enable shared linking of mysqlclient lib to root4stat
8aab3dc 
An alternative solution to the issue described in PR #343
@plexoos
Copy link
Member Author

plexoos commented May 12, 2022

Probably I should have sent a reminder earlier... but let's merge and see if the nightly build and tests on the farm can digest this change. If not we'll roll back.

@plexoos plexoos merged commit 26c28b5 into main May 12, 2022
@plexoos plexoos deleted the pr/link_mysql_dynamically branch May 12, 2022 01:31
@plexoos
Copy link
Member Author

plexoos commented May 13, 2022

@amolhj I don't see anything wrong with the nightly tests after this merge. If you see otherwise please let me know

@plexoos plexoos mentioned this pull request May 13, 2022
Closed
@genevb
Copy link
Contributor

genevb commented Jun 1, 2022

This is a minor observation that requires no action, but just to document what I observed: This PR appears to have added ~4.5 MB of memory usage to all nightly test jobs after the 2022-05-11 AutoBuild of DEV.

@plexoos
Copy link
Member Author

plexoos commented Jun 2, 2022

Another observation is that the root4star executable size (on /afs) reduced from 33 MB to 31 MB. It is peculiar that root4star's size is 19 MB in the container.

There seems to be another small increase after 2022-05-16

The large step on or after 2022-03-06 seems to correspond to the changes in #314

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klendathu2k klendathu2k Awaiting requested review from klendathu2k klendathu2k is a code owner

@perevbnlgov perevbnlgov Awaiting requested review from perevbnlgov

@nigmatkulov nigmatkulov Awaiting requested review from nigmatkulov nigmatkulov is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@plexoos @genevb