Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Add test jobs with doEvents.C from StRoot/macros #374

Merged
merged 4 commits into from
Jul 8, 2022
Merged

ci: Add test jobs with doEvents.C from StRoot/macros #374

merged 4 commits into from
Jul 8, 2022

Conversation

plexoos
Copy link
Member

@plexoos plexoos commented Jul 2, 2022

No description provided.

@plexoos plexoos requested a review from nigmatkulov as a code owner July 2, 2022 16:38
@plexoos plexoos force-pushed the pr/run_test_macros branch 2 times, most recently from 7c9c9ca to 7c73863 Compare July 6, 2022 00:59
@veprbl
Copy link
Member

veprbl commented Jul 6, 2022 

Processing StRoot/macros/analysis/find_vertex.C("/star/rcf/test/daq/2020/351/st_physics_20351078_raw_5000001.event.root")...
Error: Syntax error StRoot/macros/analysis/find_vertex.C:31:
Error: Missing one of ',;' expected at or after line 31.
Error: Unexpected end of file (G__fignorestream():3) StRoot/macros/analysis/find_vertex.C:261:
*** Interpreter error recovered ***

I'm not sure what it wants here. I've tried throwing the https://github.com/star-bnl/star-sw/blob/main/StRoot/macros/analysis/find_vertex.C into godbolt and it didn't give me any syntax errors (there were other compilation errors of course).

@plexoos plexoos mentioned this pull request Jul 6, 2022
Closed
@plexoos
Copy link
Member Author

plexoos commented Jul 6, 2022

I think I know what it wants... We'll see in #375

@plexoos plexoos requested a review from genevb as a code owner July 7, 2022 21:54
genevb
genevb reviewed Jul 8, 2022
View reviewed changes
Copy link
Contributor

@genevb genevb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

find_vertex.C (under a directory I review): I have no objections to the proposed changes.

@plexoos plexoos merged commit 366eff8 into star-bnl:main Jul 8, 2022
@plexoos plexoos deleted the pr/run_test_macros branch July 8, 2022 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@genevb genevb genevb left review comments

@nigmatkulov nigmatkulov Awaiting requested review from nigmatkulov nigmatkulov is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@plexoos @veprbl @genevb