-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug fix on tower Et calculation for the tower selection before jet finder #403
Conversation
… the origin in towers/StjTowerEnergyCutEt.h, the original version is renamed to towers/StjTowerEnergyCutEt0.h
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable. A suggestion for optimizing the code is noted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To my knowledge this maker StJetMaker is not used in any official production chains so no objections from my side
Dmitri and Ting, could you please take a look, comment or approve this PR? I think the green merge button can only appear when all code-owners approve. Thanks |
Co-authored-by: Dmitry Kalinkin <dmitry.kalinkin@gmail.com>
A bug fix on tower Et calculation using the collision vertex instead of the origin in towers/StjTowerEnergyCutEt.h