Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set search paths for included files for ROOT C++ interpreter #441

Merged
merged 1 commit into from
Nov 16, 2022

Conversation

plexoos
Copy link
Member

@plexoos plexoos commented Nov 13, 2022

It is my understanding that TSystem::AddIncludePath() sets search paths to look for header files only when ACLiC is used. On the other hand, TInterpreter::AddIncludePath() sets search paths used by the both interpreter and ACLiC (see the documentation at https://root.cern/root/html534/TCint.html#TCint:AddIncludePath)

It is my understanding that `TSystem::AddIncludePath()` sets search
paths to look for header files only when ACLiC is used. On the other
hand, `TInterpreter::AddIncludePath()` sets search paths used by the
both interpreter and ACLiC (see the documentation at
https://root.cern/root/html534/TCint.html#TCint:AddIncludePath)
@plexoos plexoos requested a review from genevb as a code owner November 13, 2022 17:04
@plexoos plexoos changed the title Set include paths for ROOT C++ interpreter Set search paths for included files for ROOT C++ interpreter Nov 14, 2022
@plexoos
Copy link
Member Author

plexoos commented Nov 15, 2022

Gene, looks like we need your approval. This change is instigated by #439 which seems to work for both ROOT5 and ROOT6

Copy link
Contributor

@genevb genevb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know of any reason to object. Some people may have their own rootlogon.C, but if so, then it is up to them to maintain their private versions.

@plexoos plexoos merged commit 7ff5c0d into star-bnl:main Nov 16, 2022
@plexoos plexoos deleted the pr/set_cint_include_paths branch November 16, 2022 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants